lib: add navigator.onLine by Uzlopak · Pull Request #50224 · nodejs/node · GitHub

Motivated by #50200

I did not add the ability to listen on a status change, as I expect that it is problematical as getting the online status is slow.

Using following benchmark I get 2600 ops/s. I could add to process the events online and offline, if we listen to online or offline. And then i would set a setInterval with lets say 50ms or 250 ms, and check if there was a status change and emit the corresponding event. Maybe if we have listeners, than instead of directly calling getOnlineStatus, we use the last value derived in the setInterval.

But for now, this is an proposal. Maybe you dont like it and we can stomp this PR into the trashbin :P

'use strict';

const common = require('../common.js');
const assert = require('assert');

const bench = common.createBenchmark(main, {
  n: [1e4],
});

// Warm up.
const length = 1024;
const array = [];
for (let i = 0; i < length; ++i) {
  array.push(global.navigator.onLine);
}

function main({ n }) {
  bench.start();
  for (let i = 0; i < n; ++i) {
    const index = i % length;
    array[index] = global.navigator.onLine;
  }
  bench.end(n);

  // Verify the entries to prevent dead code elimination from making
  // the benchmark invalid.
  for (let i = 0; i < length; ++i) {
    assert.strictEqual(typeof array[i], 'boolean');
  }
}

I investigated getifaddrs used by libuv is just horribly slow. I dont think that fast path makes a difference, when the underlying function call is simply too slow.

As explained in #39540, I doubt that this is helpful. The existence of non-loopback interfaces does not imply that the device is online.

I understand that for some web applications, being able to detect when the user's (mobile) device has lost connectivity might be important. Also, some browsers allow users to explicitly enable an "offline mode," in which case navigator.onLine also returns false.

However, even in browsers, this is widely unreliable, which is why it is often coupled with actual connectivity checks. The only benefit of navigator.onLine is avoiding additional checks if the property is false. However, if the property is false, then any additional attempt at connecting to a remote resource (e.g., through fetch()) should fail immediately. In other words, even in the unlikely scenario that navigator.onLine is false, the benefit is marginal.

Further, only a fraction of Node.js deployments are on mobile devices that might benefit from this. Enterprise deployments on servers as well as within containers will likely have network setups that will always cause this property to be true.

In command-line tools and such, checking navigator.onLine before fetching some remote resource is not good practice either, similar to how calling fs.exists before reading a file is bad practice.

This implementation is also not spec-compliant unless the relevant events are fired as described in the HTML standard. (We don't have to implement any properties from the HTML standard. The whole navigator object was designed for browsers, not for server-side runtimes. But if we do implement some of those properties, they should at least be spec-compliant.)

On the other hand, always returning true would be spec-compliant and not much less useful than this implementation. It eliminates the need for firing events because the value never changes. (Of course, I'm not actually in favor of adding such a property.)

I am not pushing this. I am just proposing. Maybe it helps to make a final decision regarding navigator being fully implemented or being ripped out.

Let’s please ping @nodejs/web-standards for all issues and PRs related to navigator.

lgtm

I have to agree with @tniessen's view on this one not being entirely useful and inherently unreliable for most Node.js use cases.

I am not pushing this. I am just proposing. Maybe it helps to make a final decision regarding navigator being fully implemented or being ripped out.

I don’t think “fully implemented” is something that’s being considered. Bun and Deno each only implement a handful of navigator properties, and among browsers there are certain properties that only some browsers support. I think Node should implement as many as possible for compatibility reasons, just to help allow as much browser code as possible run server-side successfully; but we shouldn’t implement properties that we just can’t implement successfully. As in, we shouldn’t add a property with a dummy value just so that some browser code runs without throwing a ReferenceError; if the browser code is actually doing something with the value, that part should work too.

Filed WinterTC55/proposal-minimum-common-api#61 to discuss the inclusion of Navigator attributes.

(Note: Node.js didn't declare itself to be a WinterCG runtime at the moment so this is not a blocker)

I'm not at all convinced this should be added. While the conversation is pending, I'm going to add an explicit -1 to ensure this doesn't get landed in the meantime.

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem. typings labels Oct 17, 2023

Uzlopak force-pushed the add-navigator-onLine branch 4 times, most recently from 8fd4121 to 9969108 Compare October 17, 2023 23:18

H4ad reviewed Oct 17, 2023

View reviewed changes

Comment thread src/node_os.cc

Uzlopak force-pushed the add-navigator-onLine branch 2 times, most recently from 96c1f55 to e8e0e9b Compare October 17, 2023 23:48

anonrig reviewed Oct 18, 2023

View reviewed changes

Comment thread typings/internalBinding/os.d.ts Outdated

Comment thread src/node_os.cc

Comment thread doc/api/globals.md Outdated

Comment thread doc/api/globals.md Outdated

Uzlopak force-pushed the add-navigator-onLine branch from e8e0e9b to 18a1f74 Compare October 18, 2023 01:38

lib: add navigator.onLine

f08f756

Uzlopak force-pushed the add-navigator-onLine branch from 18a1f74 to f08f756 Compare October 18, 2023 01:47

Uzlopak force-pushed the add-navigator-onLine branch from f824b8f to f08f756 Compare October 18, 2023 04:31

tniessen reviewed Oct 19, 2023

View reviewed changes

tniessen added semver-minor PRs that contain new features and should be released in the next minor version. experimental Issues and PRs related to experimental features. labels Oct 19, 2023

tniessen mentioned this pull request Oct 19, 2023

navigator object breaks projects in v21.0.0 #50269

Closed

GeoffreyBooth added the web-standards Issues and PRs related to Web APIs label Oct 26, 2023

mcollina approved these changes Oct 28, 2023

View reviewed changes

legendecas mentioned this pull request Nov 3, 2023

Navigator APIs WinterTC55/proposal-minimum-common-api#61

Closed

jasnell requested changes Nov 11, 2023

View reviewed changes

github-actions Bot added the stale label Jul 28, 2026

panva mentioned this pull request Aug 7, 2026

lib: make Navigator WPT-compliant #65119

Open

avivkeller closed this Aug 9, 2026

lib: add navigator.onLine by Uzlopak · Pull Request #50224 · nodejs/node · GitHub

Uh oh!

Uh oh!

lib: add navigator.onLine - #50224

lib: add navigator.onLine#50224Uzlopak wants to merge 1 commit intonodejs:mainnodejs/node:mainfrom Uzlopak:add-navigator-onLineUzlopak/node:add-navigator-onLineCopy head branch name to clipboard

Conversation

Uzlopak commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uzlopak commented Oct 18, 2023

Uh oh!

tniessen left a comment

Choose a reason for hiding this comment

Uh oh!

Uzlopak commented Oct 19, 2023

Uh oh!

GeoffreyBooth commented Oct 26, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell commented Oct 28, 2023

Uh oh!

GeoffreyBooth commented Oct 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legendecas commented Nov 3, 2023

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

lib: add navigator.onLine#50224
Uzlopak wants to merge 1 commit into
nodejs:mainfrom
Uzlopak:add-navigator-onLine

Uzlopak commented Oct 17, 2023 •
edited
Loading

GeoffreyBooth commented Oct 28, 2023 •
edited
Loading