FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: set crypto-timing test as flaky by anonrig · Pull Request #50232 · nodejs/node · GitHub

/ node Public

test: set crypto-timing test as flaky - #50232

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:flaky-test-crypto-timing-safe-equal-benchmarks
Oct 20, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: set crypto-timing test as flaky#50232
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:flaky-test-crypto-timing-safe-equal-benchmarks

Conversation

anonrig commented Oct 18, 2023

Copy link
Copy Markdown
Member

Ref: #38226

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2023
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54918/

anonrig added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Oct 18, 2023

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54954/

anonrig added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Oct 18, 2023

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54978/

This comment was marked as outdated.

Sign in to view
github-actions Bot mentioned this pull request Oct 19, 2023
Open
25 tasks
anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Oct 19, 2023

anonrig commented Oct 19, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/crypto can you review?

github-actions Bot mentioned this pull request Oct 20, 2023
Open
20 tasks
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2023
nodejs-github-bot merged commit eed33c9 into nodejs:main Oct 20, 2023

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

Landed in eed33c9

targos pushed a commit that referenced this pull request Oct 23, 2023
test: set crypto-timing test as flaky
5129bed 
PR-URL: #50232
Refs: #38226
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos mentioned this pull request Oct 23, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
test: set crypto-timing test as flaky
0dce19c 
PR-URL: #50232
Refs: #38226
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
test: set crypto-timing test as flaky
0c05c25 
PR-URL: #50232
Refs: #38226
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: set crypto-timing test as flaky
c5c6f33 
PR-URL: nodejs/node#50232
Refs: nodejs/node#38226
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: set crypto-timing test as flaky
4dc01ea 
PR-URL: nodejs/node#50232
Refs: nodejs/node#38226
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ruyadorno ruyadorno approved these changes
panva panva approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL