FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: set `test-emit-after-on-destroyed` as flaky by anonrig · Pull Request #50246 · nodejs/node · GitHub

/ node Public

test: set test-emit-after-on-destroyed as flaky - #50246

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:test-emit-after-on-destroyed
Oct 20, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: set test-emit-after-on-destroyed as flaky#50246
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:test-emit-after-on-destroyed

Conversation

anonrig commented Oct 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Ref: #50245

cc @nodejs/async_hooks

nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2023
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
anonrig added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Oct 18, 2023

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54952/

aduh95 commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

@nodejs/platform-aix

anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 18, 2023

github-actions Bot commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 18, 2023

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54980/

github-actions Bot mentioned this pull request Oct 19, 2023
Open
25 tasks
anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 19, 2023

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55013/

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55026/

github-actions Bot mentioned this pull request Oct 20, 2023
Open
20 tasks
mhdawson approved these changes Oct 20, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55051/

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2023
nodejs-github-bot merged commit 2d24518 into nodejs:main Oct 20, 2023

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

Landed in 2d24518

This was referenced Oct 21, 2023
Open
Open
targos pushed a commit that referenced this pull request Oct 23, 2023
test: set test-emit-after-on-destroyed as flaky
3b80a68 
Ref: #50245
PR-URL: #50246
Refs: #50245
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos mentioned this pull request Oct 23, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
test: set test-emit-after-on-destroyed as flaky
ab5985d 
Ref: #50245
PR-URL: #50246
Refs: #50245
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
test: set test-emit-after-on-destroyed as flaky
1047d95 
Ref: #50245
PR-URL: #50246
Refs: #50245
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos mentioned this pull request Nov 28, 2023
Merged
juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: set test-emit-after-on-destroyed as flaky
48bbefb 
Ref: nodejs/node#50245
PR-URL: nodejs/node#50246
Refs: nodejs/node#50245
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: set test-emit-after-on-destroyed as flaky
31826c7 
Ref: nodejs/node#50245
PR-URL: nodejs/node#50246
Refs: nodejs/node#50245
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva approved these changes
GeoffreyBooth GeoffreyBooth approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL