FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix `test-loaders-workers-spawned` flakiness by aduh95 · Pull Request #50251 · nodejs/node · GitHub

/ node Public

test: fix test-loaders-workers-spawned flakiness - #50251

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:test-loaders-workers-spawned
Oct 19, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: fix test-loaders-workers-spawned flakiness#50251
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:test-loaders-workers-spawned

Conversation

aduh95 commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

Fixes: #50247

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2023
aduh95 mentioned this pull request Oct 18, 2023
Closed
anonrig added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 18, 2023

github-actions Bot commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

anonrig added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Oct 18, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54956/

lpinca approved these changes Oct 18, 2023
View reviewed changes

lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54974/

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54976/

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54984/

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54991/

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54992/

test: deflake test-loaders-workers-spawned
765339a 
PR-URL: nodejs#50251
Fixes: nodejs#50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 force-pushed the test-loaders-workers-spawned branch from ba1b4c7 to 765339a Compare October 19, 2023 08:45
aduh95 merged commit 765339a into nodejs:main Oct 19, 2023

aduh95 commented Oct 19, 2023

Copy link
Copy Markdown
Contributor Author

Landed in 765339a

aduh95 deleted the test-loaders-workers-spawned branch October 19, 2023 08:47
This was referenced Oct 20, 2023
Open
Open
targos pushed a commit that referenced this pull request Oct 23, 2023
test: deflake test-loaders-workers-spawned
317e447 
PR-URL: #50251
Fixes: #50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Oct 23, 2023
Merged
targos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 11, 2023
test: deflake test-loaders-workers-spawned
5c56081 
PR-URL: #50251
Fixes: #50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
test: deflake test-loaders-workers-spawned
bd6512e 
PR-URL: nodejs#50251
Fixes: nodejs#50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 23, 2023
test: deflake test-loaders-workers-spawned
c1a8ae3 
PR-URL: #50251
Backport-PR-URL: #50669
Fixes: #50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: deflake test-loaders-workers-spawned
9de29ed 
PR-URL: nodejs/node#50251
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: deflake test-loaders-workers-spawned
48da608 
PR-URL: nodejs/node#50251
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
anonrig anonrig approved these changes
H4ad H4ad approved these changes

Assignees

No one assigned

Labels

esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

es-module/test-loaders-workers-spawned is flaky

6 participants

Back | FazBrowse Home | New Git URL