FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: set inspector async hook test as flaky by anonrig · Pull Request #50252 · nodejs/node · GitHub

/ node Public

test: set inspector async hook test as flaky - #50252

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:test-inspector-async-hook-setup-at-inspect-brk
Oct 18, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: set inspector async hook test as flaky#50252
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:test-inspector-async-hook-setup-at-inspect-brk

Conversation

anonrig commented Oct 18, 2023

Copy link
Copy Markdown
Member

Ref: #50222

anonrig added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 18, 2023

github-actions Bot commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54959/

H4ad added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 18, 2023

lpinca commented Oct 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

The referenced issue was opened 19 hours ago. I think we should at least ping @nodejs/platform-s390 before marking the test flaky.

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2023
nodejs-github-bot merged commit e0bbe56 into nodejs:main Oct 18, 2023

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

Landed in e0bbe56

targos pushed a commit that referenced this pull request Oct 23, 2023
test: set inspector async hook test as flaky
c874490 
Ref: #50222
PR-URL: #50252
Refs: #50222
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos mentioned this pull request Oct 23, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
test: set inspector async hook test as flaky
8b260c5 
Ref: #50222
PR-URL: #50252
Refs: #50222
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
test: set inspector async hook test as flaky
866a399 
Ref: #50222
PR-URL: #50252
Refs: #50222
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: set inspector async hook test as flaky
135bb52 
Ref: nodejs/node#50222
PR-URL: nodejs/node#50252
Refs: nodejs/node#50222
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: set inspector async hook test as flaky
f769e5c 
Ref: nodejs/node#50222
PR-URL: nodejs/node#50252
Refs: nodejs/node#50222
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva approved these changes
H4ad H4ad approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL