FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: set `test-watch-mode-inspect` as flaky by anonrig · Pull Request #50259 · nodejs/node · GitHub

/ node Public

test: set test-watch-mode-inspect as flaky - #50259

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:test-watch-mode-inspect-flaky
Oct 22, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: set test-watch-mode-inspect as flaky#50259
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:test-watch-mode-inspect-flaky

Conversation

anonrig commented Oct 18, 2023

Copy link
Copy Markdown
Member

Ref: #49933

cc @nodejs/test_runner

anonrig added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 18, 2023

github-actions Bot commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54982/

cjihrig commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

cc @ nodejs/test_runner

Is this actually related to the test runner?

MoLow approved these changes Oct 19, 2023
View reviewed changes

MoLow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

once I have more time I will take a deeper look into deflaking this

anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 19, 2023

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55008/

anonrig commented Oct 19, 2023

Copy link
Copy Markdown
Member Author

@MoLow Can you approve fast-track too?

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55025/

github-actions Bot mentioned this pull request Oct 20, 2023
Open
20 tasks

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55054/

mhdawson approved these changes Oct 20, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55060/

github-actions Bot mentioned this pull request Oct 21, 2023
Open
24 tasks

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55088/

github-actions Bot mentioned this pull request Oct 22, 2023
Open
29 tasks
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2023
nodejs-github-bot merged commit d370ed0 into nodejs:main Oct 22, 2023

nodejs-github-bot commented Oct 22, 2023

Copy link
Copy Markdown
Collaborator

Landed in d370ed0

github-actions Bot mentioned this pull request Oct 23, 2023
Open
26 tasks
targos pushed a commit that referenced this pull request Oct 23, 2023
test: set test-watch-mode-inspect as flaky
63b7059 
PR-URL: #50259
Refs: #49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos mentioned this pull request Oct 23, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
test: set test-watch-mode-inspect as flaky
baa04b7 
PR-URL: #50259
Refs: #49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
test: set test-watch-mode-inspect as flaky
a0bb30c 
PR-URL: #50259
Refs: #49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos mentioned this pull request Nov 28, 2023
Merged
juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: set test-watch-mode-inspect as flaky
b856418 
PR-URL: nodejs/node#50259
Refs: nodejs/node#49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: set test-watch-mode-inspect as flaky
c9cab9b 
PR-URL: nodejs/node#50259
Refs: nodejs/node#49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

GeoffreyBooth GeoffreyBooth approved these changes
MoLow MoLow approved these changes
H4ad H4ad approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL