FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v20.x backport] backport: esm: require braces for modules code by GeoffreyBooth · Pull Request #50268 · nodejs/node · GitHub

/ node Public

[v20.x backport] backport: esm: require braces for modules code - #50268

Closed
GeoffreyBooth wants to merge 1 commit into
nodejs:v20.x-stagingfrom
GeoffreyBooth:backport-49657-to-20
Closed

[v20.x backport] backport: esm: require braces for modules code#50268
GeoffreyBooth wants to merge 1 commit into
nodejs:v20.x-stagingfrom
GeoffreyBooth:backport-49657-to-20

Conversation

GeoffreyBooth commented Oct 19, 2023
edited
Loading

Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v20.x labels Oct 19, 2023
PR-URL: nodejs#49657
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
GeoffreyBooth changed the title src: throw DataCloneError on transfering untransferable objects; esm: require braces for modules code backport: esm: require braces for modules code Oct 19, 2023
GeoffreyBooth removed the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 19, 2023

Copy link
Copy Markdown
Collaborator

GeoffreyBooth changed the title backport: esm: require braces for modules code [v20.x backport] backport: esm: require braces for modules code Oct 19, 2023
Comment thread .eslintrc.js
Comment on lines +114 to +121
{
files: [
'lib/internal/modules/**/*.js',
],
rules: {
'curly': 'error',
},
},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you remove this to avoid getting error when backporting commits that landed before this rule was introduced?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If there are commits to backport from before this rule, I highly recommend to backport them first.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't know if they actually are any, regardless having less strict lint rules on LTS lines seems like a good idea to me, but it's just a nit

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

So I looked into this, and the only two commits from before this rule are:

So I think the rule is fine to backport, and I’d rather not create unnecessary divergences from main. This rule is also very easy to abide by, and the linter can fix for it automatically.

targos commented Nov 11, 2023

Copy link
Copy Markdown
Member

Landed in 0103979

targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #49657
Backport-PR-URL: #50268
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
targos closed this Nov 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL