| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Review requested:
|
Sorry, something went wrong.
PR-URL: nodejs#49657 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Sorry, something went wrong.
| { | ||
| files: [ | ||
| 'lib/internal/modules/**/*.js', | ||
| ], | ||
| rules: { | ||
| 'curly': 'error', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Can you remove this to avoid getting error when backporting commits that landed before this rule was introduced?
Sorry, something went wrong.
There was a problem hiding this comment.
If there are commits to backport from before this rule, I highly recommend to backport them first.
Sorry, something went wrong.
There was a problem hiding this comment.
I don't know if they actually are any, regardless having less strict lint rules on LTS lines seems like a good idea to me, but it's just a nit
Sorry, something went wrong.
There was a problem hiding this comment.
So I looked into this, and the only two commits from before this rule are:
So I think the rule is fine to backport, and I’d rather not create unnecessary divergences from main. This rule is also very easy to abide by, and the linter can fix for it automatically.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This backports:
Resolves #49657 (comment).