fixup! test: set test-worker-nearheaplimit-deadlock flaky - #50277
Closed
StefanStojanovic wants to merge 1 commit into
Closed
fixup! test: set test-worker-nearheaplimit-deadlock flaky#50277StefanStojanovic wants to merge 1 commit into
StefanStojanovic wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
richardlau
approved these changes
Oct 19, 2023
Copy link
Copy Markdown
Member
|
I edited the OP to remove the Fixes link. We should not close issues when the test is marked as flaky, only when it's actually fixed. |
Sorry, something went wrong.
StefanStojanovic
force-pushed
the
mefi-test-worker-nearheaplimit-deadlock-flaky-2
branch
from
4b081e1 to
bae1e41
Compare
October 19, 2023 12:00
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Makes sense! Btw, I had to change the commit message since having fixup part made it longer than 72 characters. |
Sorry, something went wrong.
anonrig
approved these changes
Oct 19, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
20 tasks
Copy link
Copy Markdown
Contributor
Author
|
Can someone please request Fast-track for this? I saw it failing in other PRs often. I think it would be beneficial to land this ASAP. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @richardlau. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/50277 ✔ Done loading data for nodejs/node/pull/50277 ----------------------------------- PR info ------------------------------------ Title fixup! test: set test-worker-nearheaplimit-deadlock flaky (#50277) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch StefanStojanovic:mefi-test-worker-nearheaplimit-deadlock-flaky-2 -> nodejs:main Labels test, fast-track, author ready, needs-ci Commits 1 - test: set test-worker-nearheaplimit-deadlock flaky Committers 1 - StefanStojanovic PR-URL: https://github.com/nodejs/node/pull/50277 Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50277 Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 19 Oct 2023 10:58:20 GMT ✔ Approvals: 2 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/50277#pullrequestreview-1687369552 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50277#pullrequestreview-1687520300 ℹ This PR is being fast-tracked ✘ This PR needs to wait 23 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-10-19T17:01:00Z: https://ci.nodejs.org/job/node-test-pull-request/55019/ - Querying data for job/node-test-pull-request/55019/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6586894859 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
From what I see this is why it failed ✘ This PR needs to wait 23 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). I've approved fast-track, but I'm not a collaborator, so someone else has to do it. |
Sorry, something went wrong.
mhdawson
approved these changes
Oct 20, 2023
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
mhdawson
pushed a commit
that referenced
this pull request
Oct 20, 2023
PR-URL: #50277 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
24 tasks
targos
pushed a commit
that referenced
this pull request
Oct 23, 2023
PR-URL: #50277 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50277 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
PR-URL: #50277 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#50277 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#50277 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is only flaky on x86 Windows.
This is a fixup to #50238 because process.arch returns ia32 and not x86 on x86 node.exe on Windows.