FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix hardwareConcurrency example by tniessen · Pull Request #50278 · nodejs/node · GitHub

/ node Public

doc: fix hardwareConcurrency example - #50278

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
tniessen:navigator-is-bad
Oct 23, 2023
ConversationCommits (1)ChecksFiles changed
Merged

doc: fix hardwareConcurrency example#50278
aduh95 merged 1 commit into
nodejs:mainfrom
tniessen:navigator-is-bad

Conversation

tniessen commented Oct 19, 2023

Copy link
Copy Markdown
Member

Refs: #47769

tniessen added doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features. labels Oct 19, 2023
tniessen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 19, 2023
H4ad added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2023

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55005/

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55017/

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55018/

Uzlopak approved these changes Oct 19, 2023
View reviewed changes

Uzlopak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tniessen commented Oct 19, 2023

Copy link
Copy Markdown
Member Author

@H4ad This PR did not need a Jenkins CI run because it touches documentation only.

H4ad commented Oct 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@tniessen Oh, thanks for letting me know.

In cases like this, should we just fast-track or there is another behavior?

tniessen commented Oct 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

In cases like this, should we just fast-track or there is another behavior?

Any collaborator may suggest fast-tracking of such small doc-only changes by adding the fast-track label. But it's perfectly reasonable for a PR like this to wait for two days to land (without Jenkins CI) since it's not urgent by any means.

IIRC, now that Jenkins CI has been started, we have to run it until it passes for the commit queue to not reject the PR, but perhaps I am misremembering or things have changed.

This was referenced Oct 20, 2023
Open
Open
Open

nodejs-github-bot commented Oct 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55113/

nodejs-github-bot commented Oct 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55121/

nodejs-github-bot commented Oct 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55122/

tniessen commented Oct 22, 2023

Copy link
Copy Markdown
Member Author

Not sure what's going on with ARM...

github-actions Bot mentioned this pull request Oct 23, 2023
Open
26 tasks
aduh95 merged commit fa514c9 into nodejs:main Oct 23, 2023

aduh95 commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

Landed in 5d33203

github-actions Bot mentioned this pull request Oct 24, 2023
Open
27 tasks
targos pushed a commit that referenced this pull request Oct 24, 2023
doc: fix navigator.hardwareConcurrency example
db2a1cf 
PR-URL: #50278
Refs: #47769
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Oct 24, 2023
Merged
github-actions Bot mentioned this pull request Oct 25, 2023
Open
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
anonrig anonrig approved these changes
richardlau richardlau approved these changes
H4ad H4ad approved these changes
+3 more reviewers
targos targos approved these changes
Uzlopak Uzlopak approved these changes
aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL