tools: drop support for osx notarization with gon - #50291
Merged
nodejs-github-bot merged 1 commit intoOct 21, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
UlisesGascon
marked this pull request as ready for review
October 19, 2023 15:47
targos
approved these changes
Oct 19, 2023
This was referenced Oct 19, 2023
lpinca
approved these changes
Oct 19, 2023
anonrig
approved these changes
Oct 19, 2023
richardlau
approved these changes
Oct 19, 2023
targos
pushed a commit
that referenced
this pull request
Oct 23, 2023
Refs: nodejs/build#3385 (comment) PR-URL: #50291 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com>
targos
pushed a commit
that referenced
this pull request
Oct 28, 2023
Refs: nodejs/build#3385 (comment) PR-URL: #50291 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Nov 7, 2023
Refs: nodejs/build#3385 (comment) PR-URL: #50291 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Refs: nodejs/build#3385 (comment) PR-URL: nodejs/node#50291 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Refs: nodejs/build#3385 (comment) PR-URL: nodejs/node#50291 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Changes
Drops support for gon in the OSX notarization process as this tool will not be supported after November 1, 2023. Only notarytool will be used from that moment.
Context
Refs: nodejs/build#3385 (comment)
Refs: Continuation for #48701
cc: @nodejs/build