FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: updated for each to for of in test file by lyannel · Pull Request #50308 · nodejs/node · GitHub

/ node Public

test: updated for each to for of in test file - #50308

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lyannel:fix/test
May 11, 2024
ConversationCommits (1)ChecksFiles changed
Merged

test: updated for each to for of in test file#50308
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lyannel:fix/test

Conversation

lyannel commented Oct 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Updated forEach to for ... of in test-http-client-default-headers-exist.js file

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 20, 2023
ZYSzys added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2023

nodejs-github-bot commented Oct 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55116/

This was referenced Oct 23, 2023
Open
Open
Open
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 28, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 28, 2023

nodejs-github-bot commented Dec 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56574/

nodejs-github-bot commented Dec 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56584/

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 11, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2024
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2024
nodejs-github-bot merged commit cbc88b6 into nodejs:main May 11, 2024

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

Landed in cbc88b6

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59129/

targos pushed a commit that referenced this pull request May 12, 2024
test: updated for each to for of in test file
4f96b00 
PR-URL: #50308
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request May 13, 2024
Merged
marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
test: updated for each to for of in test file
4102244 
PR-URL: #50308
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
test: updated for each to for of in test file
415e0a5 
PR-URL: nodejs#50308
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
ZYSzys ZYSzys approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL