test: ensure never settling promises are detected - #50318
Merged
nodejs-github-bot merged 2 commits intoOct 23, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
targos
approved these changes
Oct 21, 2023
cjihrig
approved these changes
Oct 21, 2023
MoLow
approved these changes
Oct 21, 2023
anonrig
approved these changes
Oct 21, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
panva
approved these changes
Oct 21, 2023
29 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Oct 22, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
26 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Oct 24, 2023
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50318 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50318 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It won't detect all possible cases where we forget about never-settling promises, but it should catch the most common ones.