tests: New zlib version is 1.3, which only has two elements - #50364
Merged
nodejs-github-bot merged 1 commit intoNov 2, 2023
Merged
tests: New zlib version is 1.3, which only has two elements#50364nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Background:
With this constellation, the test suite failed with [ 2208s] not ok 2407 parallel/test-process-versions
[ 2208s] ---
[ 2208s] duration_ms: 388.41800
[ 2208s] severity: fail
[ 2208s] exitcode: 1
[ 2208s] stack: |-
[ 2208s] node:assert:1026
[ 2208s] throw err;
[ 2208s] ^
[ 2208s]
[ 2208s] AssertionError [ERR_ASSERTION]: The input did not match the regular expression /^\d+(?:\.\d+){2,3}(?:-.*)?$/. Input:
[ 2208s]
[ 2208s] '1.3'
[ 2208s]
[ 2208s] at Object.<anonymous> (/home/abuild/rpmbuild/BUILD/node-v20.8.1/test/parallel/test-process-versions.js:64:8)
[ 2208s] at Module._compile (node:internal/modules/cjs/loader:1241:14)
[ 2208s] at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
[ 2208s] at Module.load (node:internal/modules/cjs/loader:1091:32)
[ 2208s] at Module._load (node:internal/modules/cjs/loader:938:12)
[ 2208s] at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
[ 2208s] at node:internal/main/run_main_module:23:47 {
[ 2208s] generatedMessage: true,
[ 2208s] code: 'ERR_ASSERTION',
[ 2208s] actual: '1.3',
[ 2208s] expected: /^\d+(?:\.\d+){2,3}(?:-.*)?$/,
[ 2208s] operator: 'match'
[ 2208s] }
|
Sorry, something went wrong.
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version.
Copy link
Copy Markdown
Member
|
I think a better approach would be to skip the assertion when Node.js is built with the --shared-zlib option as the version might not match even with the proposed regex. |
Sorry, something went wrong.
lpinca
approved these changes
Nov 1, 2023
Copy link
Copy Markdown
Member
Sorry, something went wrong.
richardlau
approved these changes
Nov 1, 2023
Copy link
Copy Markdown
Member
|
Can you please fix the commit message in accordance with our guidelines? Thank you. Neverming, commit message is ok. I was tricked by PR title. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Commit message looks okay (it was already changed from the PR title). |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
My bad - that was the 'original' commit message, saw the bot complaining about this and rewrote it - hopefully to comply |
Sorry, something went wrong.
25 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Nov 3, 2023
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: #50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
targos
pushed a commit
that referenced
this pull request
Nov 14, 2023
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: #50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
targos
pushed a commit
that referenced
this pull request
Nov 15, 2023
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: #50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
targos
pushed a commit
that referenced
this pull request
Nov 15, 2023
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: #50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: nodejs/node#50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: nodejs/node#50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the test code to accept one, two, or three elements past the major version