FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update child_process.md by joseph0007 · Pull Request #50370 · nodejs/node · GitHub

/ node Public

Update child_process.md - #50370

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
joseph0007:patch-1
Jan 7, 2024
Merged

Update child_process.md#50370
aduh95 merged 1 commit into
nodejs:mainfrom
joseph0007:patch-1

Conversation

joseph0007 commented Oct 24, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

child_process: grammatical issue was fixed with the sentence.

nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Oct 24, 2023
Comment thread doc/api/child_process.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure if "open" is the correct term here, maybe "start"? @nodejs/streams @nodejs/child_process wdyt?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not a native speaker but "start" seems better. However, I think "open" is fine too.

Comment thread doc/api/child_process.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not a native speaker but "start" seems better. However, I think "open" is fine too.

lpinca commented Oct 27, 2023

Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member

Could you lint the first commit? You can use npx core-validate-commit

Copy link
Copy Markdown
Contributor Author

Ok will change the commit message in a bit.

Copy link
Copy Markdown
Contributor Author

I won't be able to change the commit message, it will have to be done by someone with access.

aduh95 commented Jan 6, 2024

Copy link
Copy Markdown
Contributor

Here's how I fixed it:

git fetch https://github.com/nodejs/node.git main
git reset FETCH_HEAD --hard
curl -L https://github.com/nodejs/node/pull/50370.patch | git am
# here I changed `open` to `start` as suggested in the comment above
git commit --amend -m 'doc: add missing word in `child_process.md`'
git push git@github.com:joseph0007/node.git HEAD:patch-1 -f

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 6, 2024
mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 7, 2024

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 7, 2024

Copy link
Copy Markdown
Collaborator

aduh95 commented Jan 7, 2024

Copy link
Copy Markdown
Contributor

@mcollina Please refrain from starting Jenkins CI on doc-only PR, it's not required and a waste of time (both for Jenkins hosts, and volunteers who can't use the CQ while the Jenkins result is pending).

aduh95 merged commit fa95289 into nodejs:main Jan 7, 2024

aduh95 commented Jan 7, 2024

Copy link
Copy Markdown
Contributor

Landed in fa95289

mcollina commented Jan 7, 2024

Copy link
Copy Markdown
Member

That is the only way to land PRs using the commit queue. I’ll refrain from starting it and landing docs PRs from now on. (I do not have time to manually land them, as I mostly do these light reviews from mobile).

aduh95 commented Jan 7, 2024

Copy link
Copy Markdown
Contributor

That is the only way to land PRs using the commit queue

This is not correct AFAIK, the CQ is perfectly able to land doc-only PR without Jenkins CI, e.g. see it in action in #51374 or #51184

mcollina commented Jan 7, 2024

Copy link
Copy Markdown
Member

Ah my mistake. At some point it wasn’t. I’ll try it next time.

marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
PR-URL: nodejs#50370
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
PR-URL: nodejs#50370
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
PR-URL: #50370
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
marco-ippolito mentioned this pull request Mar 1, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #50370
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
richardlau mentioned this pull request Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL