| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
I'm not sure if "open" is the correct term here, maybe "start"? @nodejs/streams @nodejs/child_process wdyt?
Sorry, something went wrong.
There was a problem hiding this comment.
I'm not a native speaker but "start" seems better. However, I think "open" is fine too.
Sorry, something went wrong.
There was a problem hiding this comment.
I'm not a native speaker but "start" seems better. However, I think "open" is fine too.
Sorry, something went wrong.
|
@joseph0007 can you please fix the commit message? See https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines. |
Sorry, something went wrong.
|
Could you lint the first commit? You can use npx core-validate-commit |
Sorry, something went wrong.
|
Ok will change the commit message in a bit. |
Sorry, something went wrong.
|
I won't be able to change the commit message, it will have to be done by someone with access. |
Sorry, something went wrong.
|
Here's how I fixed it: git fetch https://github.com/nodejs/node.git main
git reset FETCH_HEAD --hard
curl -L https://github.com/nodejs/node/pull/50370.patch | git am
# here I changed `open` to `start` as suggested in the comment above
git commit --amend -m 'doc: add missing word in `child_process.md`'
git push git@github.com:joseph0007/node.git HEAD:patch-1 -f |
Sorry, something went wrong.
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Sorry, something went wrong.
|
@mcollina Please refrain from starting Jenkins CI on doc-only PR, it's not required and a waste of time (both for Jenkins hosts, and volunteers who can't use the CQ while the Jenkins result is pending). |
Sorry, something went wrong.
|
That is the only way to land PRs using the commit queue. I’ll refrain from starting it and landing docs PRs from now on. (I do not have time to manually land them, as I mostly do these light reviews from mobile). |
Sorry, something went wrong.
|
Ah my mistake. At some point it wasn’t. I’ll try it next time. |
Sorry, something went wrong.
PR-URL: nodejs#50370 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
PR-URL: nodejs#50370 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
PR-URL: #50370 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
PR-URL: #50370 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
| Back | FazBrowse Home | New Git URL |
child_process: grammatical issue was fixed with the sentence.