FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: update gyp-next to v0.16.1 by targos · Pull Request #50380 · nodejs/node · GitHub

/ node Public

tools: update gyp-next to v0.16.1 - #50380

Closed
targos wants to merge 2 commits into
nodejs:mainfrom
targos:update-gyp
ConversationCommits (2)ChecksFiles changed
Closed

tools: update gyp-next to v0.16.1#50380
targos wants to merge 2 commits into
nodejs:mainfrom
targos:update-gyp

Conversation

targos commented Oct 25, 2023

Copy link
Copy Markdown
Member

No description provided.

nodejs-github-bot commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

nodejs-github-bot added build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 25, 2023

targos commented Oct 25, 2023

Copy link
Copy Markdown
Member Author

@nodejs/python not sure what to do about https://github.com/nodejs/node/actions/runs/6636731539/job/18029693061

gengjiawen commented Oct 25, 2023

Copy link
Copy Markdown
Member

@nodejs/python not sure what to do about nodejs/node/actions/runs/6636731539/job/18029693061

ignore tools/gyp should do.

node/pyproject.toml

Line 23 in d1ccca9

"tools/node_modules",

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2023

cclauss commented Oct 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

I would comment out this line in tools/gyp/pyproject.toml
error: TOML parse error at line 94, column 3
|
94 | "PLR1714",
| ^^^^^^^^^
Unknown rule selector: PLR1714

gengjiawen commented Oct 25, 2023

Copy link
Copy Markdown
Member

I would comment out this line: error: TOML parse error at line 94, column 3 | 94 | "PLR1714", | ^^^^^^^^^ Unknown rule selector: PLR1714

In the long run, we shouldn't lint and format deps in Node.js repo. This can be done in gyp-next.

cclauss commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

Oh... This is because we are using a pinned version of ruff and gyp-next is using a current one.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2023

cclauss commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

Please update

node/Makefile

Lines 1499 to 1500 in d1ccca9

$(PYTHON) -m pip install --upgrade --target tools/pip/site-packages ruff==0.0.272 || \
$(PYTHON) -m pip install --upgrade --system --target tools/pip/site-packages ruff==0.0.272

nodejs-github-bot commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55218/

targos commented Oct 25, 2023

Copy link
Copy Markdown
Member Author

This should not be related. gyp-next is linted in its own project and I agree with @gengjiawen we should not lint it again with our own rules here.

cclauss commented Oct 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Ruff is designed to work in complex monorepos so we would not be testing the node-gyp directory using this repo’s pyproject.toml (as this error proves). Ruff parsed this file because it will be the settings used to lint that directory.

anonrig added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Oct 31, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2023

nodejs-github-bot commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

Landed in a77ef54...6557c1c

nodejs-github-bot pushed a commit that referenced this pull request Oct 31, 2023
tools: skip ruff on tools/gyp
76d4e38 
PR-URL: #50380
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
nodejs-github-bot pushed a commit that referenced this pull request Oct 31, 2023
tools: update gyp-next to v0.16.1
6557c1c 
PR-URL: #50380
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos deleted the update-gyp branch October 31, 2023 12:45
This was referenced Nov 6, 2023
Merged
Merged
targos added a commit that referenced this pull request Nov 11, 2023
tools: skip ruff on tools/gyp
de9dc10 
PR-URL: #50380
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos added a commit that referenced this pull request Nov 11, 2023
tools: update gyp-next to v0.16.1
171ae59 
PR-URL: #50380
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos mentioned this pull request Nov 12, 2023
Merged
targos added a commit that referenced this pull request Nov 14, 2023
tools: skip ruff on tools/gyp
9fc29c9 
PR-URL: #50380
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos added a commit that referenced this pull request Nov 14, 2023
tools: update gyp-next to v0.16.1
52e7b6d 
PR-URL: #50380
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
tools: skip ruff on tools/gyp
f5ccab5 
PR-URL: #50380
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
tools: update gyp-next to v0.16.1
22b7a74 
PR-URL: #50380
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
UlisesGascon mentioned this pull request Dec 12, 2023
Merged
richardlau mentioned this pull request Mar 22, 2024
Merged
joshuafried pushed a commit to joshuafried/node that referenced this pull request Sep 13, 2024
tools: update gyp-next to v0.16.1
eb4420d 
PR-URL: nodejs/node#50380
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Nov 2, 2024
tools: skip ruff on tools/gyp
fa72b2c 
PR-URL: #50380
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Nov 2, 2024
tools: update gyp-next to v0.16.1
0fb652e 
PR-URL: #50380
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 mentioned this pull request Nov 7, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
anonrig anonrig approved these changes
gengjiawen gengjiawen approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL