stream: use bit fields for construct/destroy - #50408
Merged
nodejs-github-bot merged 1 commit intoOct 28, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
ronag
force-pushed
the
bitmap-constructor-destroy
branch
from
6a5c0d6 to
3bf4eaf
Compare
October 26, 2023 13:47
ronag
force-pushed
the
bitmap-constructor-destroy
branch
from
3bf4eaf to
02e3f43
Compare
October 26, 2023 14:00
ronag
force-pushed
the
bitmap-constructor-destroy
branch
from
02e3f43 to
74712a7
Compare
October 26, 2023 14:02
mcollina
approved these changes
Oct 26, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
rluvaton
approved these changes
Oct 26, 2023
Comment thread
lib/internal/streams/utils.js
Outdated
Comment on lines
26
to
34
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
How can we enforce that readable/writable stream will not have a bit state with the same position?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Not sure. Suggestions?
Sorry, something went wrong.
Comment thread
lib/internal/streams/destroy.js
Outdated
ronag
force-pushed
the
bitmap-constructor-destroy
branch
from
74712a7 to
763eaa1
Compare
October 26, 2023 14:52
benjamingr
approved these changes
Oct 26, 2023
19 tasks
ronag
force-pushed
the
bitmap-constructor-destroy
branch
from
763eaa1 to
cea0fb4
Compare
October 27, 2023 07:00
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@ronag If the motivation of this change is performance, can you share the benchmarks? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
There is a CI benchmark |
Sorry, something went wrong.
anonrig
approved these changes
Oct 27, 2023
22 tasks
This was referenced Oct 29, 2023
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50408 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50408 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.