meta: add web-standards as web api visibility owner - #50418
Merged
nodejs-github-bot merged 2 commits intoOct 28, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
aduh95
approved these changes
Oct 26, 2023
GeoffreyBooth
approved these changes
Oct 26, 2023
GeoffreyBooth
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Maybe also any of the Web Platform Tests? Undici, fetch, ws? Are there any other paths we should cover for this team?
Sorry, something went wrong.
benjamingr
approved these changes
Oct 26, 2023
ljharb
approved these changes
Oct 26, 2023
tniessen
approved these changes
Oct 26, 2023
RaisinTen
approved these changes
Oct 27, 2023
anonrig
approved these changes
Oct 27, 2023
anonrig
reviewed
Oct 27, 2023
Comment thread
.github/CODEOWNERS
Copy link
Copy Markdown
Member
Author
|
undici is covered by its own dedicated team so I would prefer to defer it to them. Added navigator.js as suggested by @anonrig . |
Sorry, something went wrong.
anonrig
approved these changes
Oct 27, 2023
GeoffreyBooth
approved these changes
Oct 27, 2023
mcollina
approved these changes
Oct 28, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50418 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50418 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Web APIs global visibility is changed, ping @nodejs/web-standards.
Refs: #50412 (comment)