FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: remove no longer relevant comment by ronag · Pull Request #50446 · nodejs/node · GitHub

/ node Public

stream: remove no longer relevant comment - #50446

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:transform-comment
Oct 29, 2023
ConversationCommits (1)ChecksFiles changed
Merged

stream: remove no longer relevant comment#50446
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:transform-comment

Conversation

ronag commented Oct 28, 2023

Copy link
Copy Markdown
Member

No description provided.

ronag force-pushed the transform-comment branch from 26f7e4c to 49d6dc9 Compare October 28, 2023 13:22

nodejs-github-bot commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 28, 2023
benjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 28, 2023

github-actions Bot commented Oct 28, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.

benjamingr added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2023
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 28, 2023

nodejs-github-bot commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50446
✔  Done loading data for nodejs/node/pull/50446
----------------------------------- PR info ------------------------------------
Title      stream: remove no longer relevant comment (#50446)
Author     Robert Nagy  (@ronag)
Branch     ronag:transform-comment -> nodejs:main
Labels     fast-track, needs-ci
Commits    1
 - stream: remove no longer relevant comment
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/50446
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50446
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 28 Oct 2023 13:22:16 GMT
   ✔  Approvals: 3
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702792357
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702794868
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702808819
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6678101104

benjamingr added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 28, 2023
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 28, 2023

nodejs-github-bot commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50446
✔  Done loading data for nodejs/node/pull/50446
----------------------------------- PR info ------------------------------------
Title      stream: remove no longer relevant comment (#50446)
Author     Robert Nagy  (@ronag)
Branch     ronag:transform-comment -> nodejs:main
Labels     fast-track
Commits    1
 - stream: remove no longer relevant comment
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/50446
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50446
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 28 Oct 2023 13:22:16 GMT
   ✔  Approvals: 3
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702792357
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702794868
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702808819
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6678286873

MoLow added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 28, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2023

nodejs-github-bot commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55297/

VoltrexKeyva added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 29, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 29, 2023
nodejs-github-bot merged commit 12766fc into nodejs:main Oct 29, 2023

nodejs-github-bot commented Oct 29, 2023

Copy link
Copy Markdown
Collaborator

Landed in 12766fc

targos pushed a commit that referenced this pull request Nov 11, 2023
stream: remove no longer relevant comment
2c0d88e 
Refs: #50014
PR-URL: #50446
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos mentioned this pull request Nov 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
stream: remove no longer relevant comment
829b82e 
Refs: #50014
PR-URL: #50446
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
UlisesGascon mentioned this pull request Dec 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
anonrig anonrig approved these changes
MoLow MoLow approved these changes

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL