tools: update doc to highlight.js@11.9.0 remark-frontmatter@5.0.0 remark-gfm@4.0.0 remark-html@16.0.1 remark-parse@11.0.0 remark-rehype@11.0.0 unified@11.0.4 unist-util-select@5.1.0 - #50459
Conversation
Sorry, something went wrong.
|
Review requested:
|
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
|
I think the logical fix is to build the docs with a stable node binary on the without-intl job, so we don't crash the build if the deps uses a regex with the u flag. @nodejs/build how can we make this happen? IIRC the setup job is not available publicly, only a build member can do this sort of change. |
Sorry, something went wrong.
|
@aduh95 FWIW the without-intl job runs: NODE_TEST_DIR=/home/iojs/node-tmp FLAKY_TESTS=dontcare CONFIG_FLAGS=' --without-intl' make run-ci -j 4Given that we describe how to build without intl in https://github.com/nodejs/node/blob/main/BUILDING.md#building-without-intl-support I'd prefer if we had a solution that worked without involving changes to the Jenkins job -- i.e. running the Makefile after configure --without-intl should just work. |
Sorry, something went wrong.
And unist-util-select@5.1.0.
Sorry, something went wrong.
And unist-util-select@5.1.0. PR-URL: #50459 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
And unist-util-select@5.1.0. PR-URL: #50459 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This is an automated update of doc to highlight.js@11.9.0 remark-frontmatter@5.0.0 remark-gfm@4.0.0 remark-html@16.0.1 remark-parse@11.0.0 remark-rehype@11.0.0 (updating those breaks the no-intl CI) unified@11.0.4 unist-util-select@5.1.0.