FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: compare ICU checksums before file changes by targos · Pull Request #50522 · nodejs/node · GitHub

/ node Public

tools: compare ICU checksums before file changes - #50522

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:tools-icu-checksum
Nov 6, 2023
ConversationCommits (1)ChecksFiles changed
Merged

tools: compare ICU checksums before file changes#50522
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:tools-icu-checksum

Conversation

targos commented Nov 2, 2023

Copy link
Copy Markdown
Member

Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495

tools: compare ICU checksums before file changes
582ff30 
Otherwise we end up with an bad update PR when checksums don't match.

Refs: nodejs#50495

nodejs-github-bot commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 2, 2023
marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2023
nodejs-github-bot merged commit cde3296 into nodejs:main Nov 6, 2023

nodejs-github-bot commented Nov 6, 2023

Copy link
Copy Markdown
Collaborator

Landed in cde3296

targos deleted the tools-icu-checksum branch November 6, 2023 11:23
targos added a commit that referenced this pull request Nov 11, 2023
tools: compare ICU checksums before file changes
c50b9b3 
Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495
PR-URL: #50522
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Nov 12, 2023
Merged
targos added a commit that referenced this pull request Nov 14, 2023
tools: compare ICU checksums before file changes
257e220 
Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495
PR-URL: #50522
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
tools: compare ICU checksums before file changes
2fd78fc 
Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495
PR-URL: #50522
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon mentioned this pull request Dec 12, 2023
Merged
srl295 reviewed Jan 8, 2024
View reviewed changes

srl295 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I missed this but 💯 LGTM

nonumpa mentioned this pull request Apr 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

srl295 srl295 left review comments
lpinca lpinca approved these changes
richardlau richardlau approved these changes
marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL