deps: V8: cherry-pick 13192d6e10fa - #50552
Merged
nodejs-github-bot merged 1 commit intoNov 6, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Original commit message:
[riscv][tagged-ptr] Convert more Objects to Tagged<>
Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80
Bug: v8:12710
Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#89780}
Refs: v8/v8@13192d6
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
richardlau
approved these changes
Nov 4, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
approved these changes
Nov 4, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
13 tasks
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
Nov 5, 2023
- Fix v8 compilation errors, upstreamed to nodejs: nodejs/node#50552 - Remove the `-fno-strict-aliasing` flag addition. The relevant error no longer occurs. Actually, we never do this to nodejs-lts-hydrogen after nodejs 18 is packaged as nodejs-lts-hydrogen.
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Nov 5, 2023
- Fix v8 compilation errors, upstreamed to nodejs: nodejs/node#50552 - Remove the `-fno-strict-aliasing` flag addition. The relevant error no longer occurs. Actually, we never do this to nodejs-lts-hydrogen after nodejs 18 is packaged as nodejs-lts-hydrogen.
15 tasks
debadree25
approved these changes
Nov 6, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
gengjiawen
approved these changes
Nov 6, 2023
This was referenced Nov 7, 2023
20 tasks
18 tasks
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
Original commit message:
[riscv][tagged-ptr] Convert more Objects to Tagged<>
Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80
Bug: v8:12710
Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#89780}
Refs: v8/v8@13192d6
PR-URL: #50552
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 14, 2023
Original commit message:
[riscv][tagged-ptr] Convert more Objects to Tagged<>
Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80
Bug: v8:12710
Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#89780}
Refs: v8/v8@13192d6
PR-URL: #50552
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
Original commit message:
[riscv][tagged-ptr] Convert more Objects to Tagged<>
Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80
Bug: v8:12710
Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#89780}
Refs: v8/v8@13192d6
PR-URL: #50552
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 13, 2023
Original commit message:
[riscv][tagged-ptr] Convert more Objects to Tagged<>
Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80
Bug: v8:12710
Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#89780}
Refs: v8/v8@13192d6
PR-URL: #50552
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 15, 2023
Original commit message:
[riscv][tagged-ptr] Convert more Objects to Tagged<>
Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80
Bug: v8:12710
Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#89780}
Refs: v8/v8@13192d6
PR-URL: #50552
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 19, 2023
Original commit message:
[riscv][tagged-ptr] Convert more Objects to Tagged<>
Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80
Bug: v8:12710
Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#89780}
Refs: v8/v8@13192d6
PR-URL: #50552
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Jan 9, 2024
Original commit message:
[riscv][tagged-ptr] Convert more Objects to Tagged<>
Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80
Bug: v8:12710
Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#89780}
Refs: v8/v8@13192d6
PR-URL: #50552
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes compilation errors on riscv64.
See compilation errors in this build log: https://paste.rs/h6xxt
Needs to be backported to v21.x-staging.
Original commit message:
[riscv][tagged-ptr] Convert more Objects to Tagged<> Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80 Bug: v8:12710 Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830 Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#89780}Refs: v8/v8@13192d6