FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace forEach with for of by john-mcinall · Pull Request #50602 · nodejs/node · GitHub

/ node Public

test: replace forEach with for of - #50602

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
john-mcinall:nodeconf
Nov 10, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: replace forEach with for of#50602
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
john-mcinall:nodeconf

Conversation

john-mcinall commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

No description provided.

nodejs-github-bot commented Nov 7, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023

ljharb commented Nov 7, 2023

Copy link
Copy Markdown
Member

for-of is more brittle than forEach; why this change?

marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023

RafaelGSS commented Nov 7, 2023

Copy link
Copy Markdown
Member

for-of is more brittle than forEach; why this change?

This is for a workshop we're running at NodeConf. See the code-and-learn label.

RafaelGSS approved these changes Nov 7, 2023
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ljharb commented Nov 7, 2023

Copy link
Copy Markdown
Member

Alrighty; it’d still be good to have a justification provided :-)

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023

nodejs-github-bot commented Nov 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55485/

github-actions Bot mentioned this pull request Nov 8, 2023
Open
16 tasks

nodejs-github-bot commented Nov 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55494/

benjamingr commented Nov 8, 2023

Copy link
Copy Markdown
Member

for-of is more brittle than forEach; why this change?

Note this is a test file so that shouldn't be a concern

ljharb commented Nov 8, 2023

Copy link
Copy Markdown
Member

I totally agree; I’m just surprised that a learning exercise doesn’t include instructions to provide a justification.

github-actions Bot mentioned this pull request Nov 9, 2023
Open
20 tasks

nodejs-github-bot commented Nov 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55521/

github-actions Bot mentioned this pull request Nov 10, 2023
Open
18 tasks
lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
nodejs-github-bot merged commit fd4a305 into nodejs:main Nov 10, 2023

nodejs-github-bot commented Nov 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in fd4a305

github-actions Bot mentioned this pull request Nov 11, 2023
Open
27 tasks
targos pushed a commit that referenced this pull request Nov 11, 2023
test: replace forEach with for of
8c97a80 
PR-URL: #50602
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
github-actions Bot mentioned this pull request Nov 12, 2023
Open
18 tasks
targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
test: replace forEach with for of
864cd32 
PR-URL: #50602
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
test: replace forEach with for of
9f911d3 
PR-URL: #50602
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon mentioned this pull request Dec 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL