@alexweej Thank you for the contribution. Your commit email address does not appear to be associated with your GitHub account. We highly recommend fixing this, either by adding your commit email address to your GitHub account, or by re-committing using a different email address and force-pushing to the same branch (and PR).

Also, the commit message does not match the commit message guidelines. It needs to start with the prefix test:, followed by a space and an imperative verb. The length must not exceed 70 characters.

That'll teach me to use my work laptop...

@tniessen does the project prefer that we iterate on a single commit in each PR? As in, you need me to update both the PR title and the underlying commit title? Thanks again

CI: https://ci.nodejs.org/job/node-test-pull-request/55568/

CI: https://ci.nodejs.org/job/node-test-pull-request/55746/

does the project prefer that we iterate on a single commit in each PR? As in, you need me to update both the PR title and the underlying commit title? Thanks again

@alexweej We generally prefer pushing additional commits to update existing PRs, except when it comes to the commit message. The commit message of the first commit must adhere to the style guide, which is why that check is still failing on this PR. It is complaining that Replace is uppercase, so you need to change the commit message accordingly (test: replace...).

On a side note, neither the git commit author nor the committer are associated with your GitHub account. We recommend fixing this, but it is not required.

Landed in 55f3993.