test: use destructuring for accessing setting values - #50609
Merged
nodejs-github-bot merged 1 commit intoNov 11, 2023
Merged
Conversation
anonrig
approved these changes
Nov 7, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
tniessen
approved these changes
Nov 7, 2023
This was referenced Nov 8, 2023
lpinca
approved these changes
Nov 10, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
27 tasks
jasnell
reviewed
Nov 11, 2023
Comment thread
test/parallel/test-http2-session-settings.js
| ['maxHeaderSize', -1], | ||
| ['maxHeaderSize', 2 ** 32], | ||
| ].forEach((i) => { | ||
| ].forEach(([key, value]) => { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is fine but it would probably be worth changing this for a for (...) loop instead of forEach(...)
Sorry, something went wrong.
jasnell
approved these changes
Nov 11, 2023
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50609 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
18 tasks
targos
pushed a commit
that referenced
this pull request
Nov 14, 2023
PR-URL: #50609 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50609 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.