test: Replace forEach() with for ... of in test-assert-typedarray-deepequal.js - #50610
Closed
JJJ54321 wants to merge 6 commits into
Closed
test: Replace forEach() with for ... of in test-assert-typedarray-deepequal.js#50610JJJ54321 wants to merge 6 commits into
JJJ54321 wants to merge 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…t-typedarray-deepequal.js
Copy link
Copy Markdown
Member
|
@jialiu54321 Thank you for the contribution. The commit message does not match the commit message guidelines. It needs to start with the prefix test:, followed by a space and an imperative lowercase verb. The length must not exceed 70 characters. |
Sorry, something went wrong.
lpinca
reviewed
Dec 27, 2023
Comment thread
test/parallel/test-assert-typedarray-deepequal.js
Outdated
Comment thread
test/parallel/test-assert-typedarray-deepequal.js
Outdated
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
reviewed
Dec 27, 2023
Comment thread
test/parallel/test-assert-typedarray-deepequal.js
Outdated
Comment thread
test/parallel/test-assert-typedarray-deepequal.js
Outdated
Comment thread
test/parallel/test-assert-typedarray-deepequal.js
Outdated
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Dec 28, 2023
lpinca
pushed a commit
that referenced
this pull request
Dec 28, 2023
Replace `forEach()` with `for...of` in `test/parallel/test-assert-typedarray-deepequal.js`. PR-URL: #50610 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
Replace `forEach()` with `for...of` in `test/parallel/test-assert-typedarray-deepequal.js`. PR-URL: #50610 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Replace `forEach()` with `for...of` in `test/parallel/test-assert-typedarray-deepequal.js`. PR-URL: #50610 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from https://docs.google.com/spreadsheets/d/1mqLZafbDSI_2h6hijO4IYxoibjayzHYt__ZMbVc1s2A/edit#gid=0