FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace forEach with for [...] of by dygabo · Pull Request #50615 · nodejs/node · GitHub

/ node Public

test: replace forEach with for [...] of - #50615

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dygabo:nodeconf_workshop
Nov 10, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: replace forEach with for [...] of#50615
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dygabo:nodeconf_workshop

Conversation

dygabo commented Nov 7, 2023

Copy link
Copy Markdown
Member

NodeConf EU Workshop

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
dygabo force-pushed the nodeconf_workshop branch from 7b04414 to 30b1093 Compare November 8, 2023 06:33
tniessen approved these changes Nov 8, 2023
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you @dygabo!

tniessen added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 8, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2023

nodejs-github-bot commented Nov 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55499/

debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
nodejs-github-bot merged commit f662c9b into nodejs:main Nov 10, 2023

nodejs-github-bot commented Nov 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in f662c9b

targos pushed a commit that referenced this pull request Nov 11, 2023
test: replace forEach with for [...] of
924b331 
PR-URL: #50615
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
test: replace forEach with for [...] of
52b517f 
PR-URL: #50615
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
test: replace forEach with for [...] of
ea61261 
PR-URL: #50615
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
UlisesGascon mentioned this pull request Dec 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tniessen tniessen approved these changes
+1 more reviewer
debadree25 debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL