build: fix GN configuration for deps/base64 - #50696
Merged
nodejs-github-bot merged 1 commit intoNov 17, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
zcbenz
force-pushed
the
fix-base64-gn-config
branch
from
50fcaf1 to
e4a552d
Compare
November 13, 2023 08:20
This comment was marked as resolved.
zcbenz
force-pushed
the
fix-base64-gn-config
branch
from
e4a552d to
d8b5162
Compare
November 13, 2023 09:35
This comment was marked as resolved.
lpinca
approved these changes
Nov 13, 2023
marco-ippolito
approved these changes
Nov 13, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
27 tasks
gengjiawen
approved these changes
Nov 14, 2023
targos
pushed a commit
that referenced
this pull request
Nov 23, 2023
PR-URL: #50696 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 27, 2023
PR-URL: nodejs#50696 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 29, 2023
PR-URL: #50696 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50696 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 19, 2023
PR-URL: #50696 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#50629 was merged right after we merged GN files.
/cc @lpinca