FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix links order in Assert doc by estliberitas · Pull Request #5074 · nodejs/node · GitHub

/ node Public

doc: fix links order in Assert doc - #5074

Closed
estliberitas wants to merge 1 commit into
nodejs:masterfrom
estliberitas:doc-assert-link-order
Closed

doc: fix links order in Assert doc#5074
estliberitas wants to merge 1 commit into
nodejs:masterfrom
estliberitas:doc-assert-link-order

Conversation

Copy link
Copy Markdown
Contributor

Sort links in lexical order

Sort links in lexical order
thefourtheye added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Feb 4, 2016
Comment thread doc/api/assert.markdown
[`Error`]: errors.html#errors_class_error
[`RegExp`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions
[`TypeError`]: errors.html#errors_class_typeerror
[Locked]: documentation.html#documentation_stability_index

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Wouldn't this come just before RegExp if it is in lexical (aka alphabetical) order?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@DavidTPate lexicographic !== alphabetic from what I know

Like: lexical (lexicographic) ⊃ alphabetical

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Something just doesn't seem right, Lexicographic on Wikipedia for example.

the lexicographic or lexicographical order (also known as lexical order, dictionary order, alphabetical order or lexicographic(al) product) is a generalization of the way the alphabetical order of words is based on the alphabetical order of their component letters.

This isn't ordered by the ASCII values as A (#65) comes before a (#97) in ASCII values. As an example:

['Locked', 'assert.deepEqual()', 'assert.deepStrictEqual()', 'assert.ok()','Error','RegExp', 'TypeError'].sort();
// ["Error", "Locked", "RegExp", "TypeError", "assert.deepEqual()", "assert.deepStrictEqual()", "assert.ok()"]

'RegExp' > 'Locked';
// true

I'm not trying to hold this PR up, just lost as to how this ordering occurred and wondering if the other PRs are in an odd order as well.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah, yes, talking about case - I used case-insensitive check. So talking about alphabet, I used case-insensitive one. 😉

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It all started with #5003, so I assumed, this is a good way to go.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Btw, maybe that's me who misunderstands lex and alphabetical order...

jasnell commented Feb 4, 2016

Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Contributor

Hmm, this one is borderline of being unneccessary in my eyes. Do links in other docs conform to a sorting? Maybe handle them all in one PR here?

Copy link
Copy Markdown
Contributor Author

@silverwind I'm ok with that

Copy link
Copy Markdown
Contributor

I'll close this one then as it barely has any value, if you wanna do it for all docs, follow up with a new one 😉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL