doc: document non-node_modules-only runtime deprecation - #50748
doc: document non-node_modules-only runtime deprecation#50748nodejs-github-bot merged 4 commits into
Conversation
Sorry, something went wrong.
We already have this special kind of runtime deprecation for Buffer constructors which does not fit into the original description of runtiem deprecations. Document this kind of deprecation separately.
|
cc @nodejs/tsc |
Sorry, something went wrong.
tniessen
left a comment
There was a problem hiding this comment.
We only have one such case and I am not sure if it's a pattern we want to extend upon, so I am also not sure if further distinction into four levels makes sense.
Sorry, something went wrong.
I didn't even know this possibility existed. There are many modules features where we would want such a "my code only" warning. |
Sorry, something went wrong.
The reason why we had this case was because Buffer constructor was too widely used so that we had many complaints from users after emitting the warnings by default and it encouraged disabling warnings (especially for CLIs that spawn child processes). I am fairly certain that this would happen again soon, looking at our recent deprecation discussions. |
Sorry, something went wrong.
mcollina
left a comment
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
|
There is a typo in commit message. runtiem -> runtime. |
Sorry, something went wrong.
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
We already have this special kind of runtime deprecation for Buffer constructors which does not fit into the original description of runtiem deprecations. Document this kind of deprecation separately. PR-URL: #50748 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
We already have this special kind of runtime deprecation for Buffer constructors which does not fit into the original description of runtiem deprecations. Document this kind of deprecation separately. PR-URL: #50748 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
We already have this special kind of runtime deprecation for Buffer constructors which does not fit into the original description of runtiem deprecations. Document this kind of deprecation separately.