FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace forEach to for.. test-webcrypto-export-import-cfrg.js by aparzi · Pull Request #50785 · nodejs/node · GitHub

/ node Public

test: replace forEach to for.. test-webcrypto-export-import-cfrg.js - #50785

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aparzi:fix-for-loop
Dec 1, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: replace forEach to for.. test-webcrypto-export-import-cfrg.js#50785
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aparzi:fix-for-loop

Conversation

aparzi commented Nov 18, 2023

Copy link
Copy Markdown
Contributor

fix for loop

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 18, 2023
marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 18, 2023
RafaelGSS requested changes Nov 24, 2023
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you follow our commit guidelines? You might want to squash all the commits too.

aparzi commented Nov 24, 2023

Copy link
Copy Markdown
Contributor Author

Hi @RafaelGSS,
Could you tell me what and how to fix? Thank you

RafaelGSS commented Nov 24, 2023

Copy link
Copy Markdown
Member

Try the following:

git rebase -i HEAD~3

Go to your first commit and change pick to edit, the other two commits you use squash, then it will open a editor to edit the first commit, so you follow our commit guidelines, in this case changing the commit to:

test: replace forEach to for.. test-webcrypto-export-import-cfrg.js

aparzi commented Nov 24, 2023

Copy link
Copy Markdown
Contributor Author

Hi @RafaelGSS,
I collapsed everything into one commit

RafaelGSS reviewed Nov 27, 2023
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@aparzi If you look at the commit list, the author doesn't seem your github handle (@aparzi)

Also, the commit length oversizes our commit guideline. See https://github.com/nodejs/node/actions/runs/6982553346/job/19058853209?pr=50785

aparzi commented Nov 27, 2023

Copy link
Copy Markdown
Contributor Author

Hi @RafaelGSS, could you check now?

aparzi commented Nov 28, 2023

Copy link
Copy Markdown
Contributor Author

Hi @RafaelGSS, any news for this PR? Thanks

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2023

nodejs-github-bot commented Nov 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56013/

RafaelGSS changed the title fix for loop test: replace forEach to for.. test-webcrypto-export-import-cfrg.js Dec 1, 2023
RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Dec 1, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 1, 2023
nodejs-github-bot merged commit 60ffa9f into nodejs:main Dec 1, 2023

nodejs-github-bot commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

Landed in 60ffa9f

targos pushed a commit that referenced this pull request Dec 4, 2023
test: replace forEach to for.. test-webcrypto-export-import-cfrg.js
3a1c664 
PR-URL: #50785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos mentioned this pull request Dec 4, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
test: replace forEach to for.. test-webcrypto-export-import-cfrg.js
1c28db8 
PR-URL: #50785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL