FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace foreach test-stream-pipe-unpipe-stream.js by DevPres · Pull Request #50786 · nodejs/node · GitHub

/ node Public

test: replace foreach test-stream-pipe-unpipe-stream.js - #50786

Merged
aduh95 merged 5 commits into
nodejs:mainfrom
DevPres:replace-forEach
May 12, 2024
ConversationCommits (5)ChecksFiles changed
Merged

test: replace foreach test-stream-pipe-unpipe-stream.js#50786
aduh95 merged 5 commits into
nodejs:mainfrom
DevPres:replace-forEach

Conversation

DevPres commented Nov 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR replace forEach() with for..of cycle.

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 18, 2023
marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 18, 2023
RafaelGSS requested changes Nov 24, 2023
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please address the lint issues and include email and username to git commit. Can you --resetAuthor after configuring your git? (git config user.name ...)

DevPres commented Nov 25, 2023

Copy link
Copy Markdown
Contributor Author

Hi @RafaelGSS , i fix the lint issue, and set git config. Let me know if it's ok. Thanks for your revision

RafaelGSS reviewed Nov 27, 2023
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @DevPres, looks like you'll need to squash your commits into one. Can you do that?

DevPres commented Nov 28, 2023

Copy link
Copy Markdown
Contributor Author

@RafaelGSS Did it! let me know if it's ok! thank for your time!

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2023
RafaelGSS reviewed Dec 4, 2023
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Your PR changes a bit more than forEach -> for .. of. Can you revert the unrelated changes?

RafaelGSS removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2023
lpinca approved these changes Dec 15, 2023
View reviewed changes
Comment thread test/parallel/test-stream-pipe-unpipe-streams.js Outdated
Comment thread test/parallel/test-stream-pipe-unpipe-streams.js Outdated
Comment thread test/parallel/test-stream-pipe-unpipe-streams.js Outdated
Comment thread test/parallel/test-stream-pipe-unpipe-streams.js Outdated
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2023

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Dec 22, 2023 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56447/ 💛

jasnell requested a review from RafaelGSS December 23, 2023 17:15
jasnell added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. and removed needs-ci PRs that need a full CI run. labels Dec 23, 2023

aduh95 commented May 3, 2024

Copy link
Copy Markdown
Contributor

@RafaelGSS are you still blocking this PR?

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024

nodejs-github-bot commented May 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58955/

nodejs-github-bot commented May 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58962/

nodejs-github-bot commented May 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58966/

aduh95 force-pushed the replace-forEach branch from 9d807ac to 491e86c Compare May 6, 2024 07:07

nodejs-github-bot commented May 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58977/

nodejs-github-bot commented May 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58985/

nodejs-github-bot commented May 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59080/

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59092/

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59130/

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59151/

aduh95 merged commit 06cde5c into nodejs:main May 12, 2024

aduh95 commented May 12, 2024

Copy link
Copy Markdown
Contributor

Landed in 06cde5c

targos pushed a commit that referenced this pull request May 12, 2024
test: replace forEach() in test-stream-pipe-unpipe-stream
cd00cdc 
PR-URL: #50786
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request May 13, 2024
Merged
marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
test: replace forEach() in test-stream-pipe-unpipe-stream
800b6f6 
PR-URL: #50786
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
test: replace forEach() in test-stream-pipe-unpipe-stream
1e12d1d 
PR-URL: nodejs#50786
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL