test: replace foreach test-fs-readv.js test-fs-readv-sync.js - #50787
Closed
FabrizioDiPace wants to merge 0 commit into
Closed
test: replace foreach test-fs-readv.js test-fs-readv-sync.js#50787FabrizioDiPace wants to merge 0 commit into
FabrizioDiPace wants to merge 0 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
If you are going for performance improvements, I recommend using traditional for loops instead (for (let i = 0; i<wrongInputs.length; i++) { }). Don't forget to run make lint-js
Sorry, something went wrong.
jasnell
approved these changes
Nov 19, 2023
marco-ippolito
approved these changes
Nov 20, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Nov 24, 2023
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/50787 ✔ Done loading data for nodejs/node/pull/50787 ----------------------------------- PR info ------------------------------------ Title test: replace foreach test-fs-readv.js test-fs-readv-sync.js (#50787) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch FabrizioDiPace:main -> nodejs:main Labels test, code-and-learn, needs-ci Commits 2 - test: replace forEach test-fa-readv-sync - Merge branch 'nodejs:main' into main Committers 2 - Ospite Privilegiato - GitHub PR-URL: https://github.com/nodejs/node/pull/50787 Reviewed-By: James M Snell Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50787 Reviewed-By: James M Snell Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 18 Nov 2023 16:01:57 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50787#pullrequestreview-1738723027 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/50787#pullrequestreview-1740123948 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50787#pullrequestreview-1748278556 ℹ This PR is being fast-tracked because it is from a Code and Learn event ⚠ GitHub cannot link the author of 'test: replace forEach test-fa-readv-sync' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-11-24T13:50:06Z: https://ci.nodejs.org/job/node-test-pull-request/55889/ - Querying data for job/node-test-pull-request/55889/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50787 From https://github.com/nodejs/node * branch refs/pull/50787/merge -> FETCH_HEAD ✔ Fetched commits as 215f4d04b7a9..cfda24f935e3 -------------------------------------------------------------------------------- error: commit cfda24f935e345976044b24b86a5d05045606aa6 is a merge but no -m option was given. fatal: cherry-pick failed [main 350ce87c78] test: replace forEach test-fa-readv-sync Author: Ospite Privilegiato Date: Sat Nov 18 16:40:37 2023 +0100 2 files changed, 8 insertions(+), 9 deletions(-) ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/7223832710 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Can you please remove the merge commit? Thank you. |
Sorry, something went wrong.
UlisesGascon
approved these changes
Dec 16, 2023
lpinca
pushed a commit
that referenced
this pull request
Dec 29, 2023
Replace `Array.prototype.forEach()` with `for...of` in `test/parallel/test-fs-readv-sync.js` and `test/parallel/test-fs-readv.js`. PR-URL: #50787 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
Replace `Array.prototype.forEach()` with `for...of` in `test/parallel/test-fs-readv-sync.js` and `test/parallel/test-fs-readv.js`. PR-URL: #50787 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Replace `Array.prototype.forEach()` with `for...of` in `test/parallel/test-fs-readv-sync.js` and `test/parallel/test-fs-readv.js`. PR-URL: #50787 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR replace foreach with forof in test-fs-readv.js test-fs-readv-sync.js