FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace forEach with for-of in test-webcrypto-export-import-ec by cricciardi · Pull Request #50793 · nodejs/node · GitHub

/ node Public

test: replace forEach with for-of in test-webcrypto-export-import-ec - #50793

Closed
cricciardi wants to merge 1 commit into
nodejs:mainfrom
cricciardi:main
ConversationCommits (1)ChecksFiles changed
Closed

test: replace forEach with for-of in test-webcrypto-export-import-ec#50793
cricciardi wants to merge 1 commit into
nodejs:mainfrom
cricciardi:main

Conversation

cricciardi commented Nov 18, 2023

Copy link
Copy Markdown
Contributor

test: replace forEach with for-of in test-webcrypto-export-import-ec

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 18, 2023
jasnell reviewed Nov 19, 2023
View reviewed changes
Comment thread test/parallel/test-webcrypto-export-import-ec.js Outdated
jasnell reviewed Nov 19, 2023
View reviewed changes
Comment thread test/parallel/test-webcrypto-export-import-ec.js Outdated
jasnell reviewed Nov 19, 2023
View reviewed changes
Comment thread test/parallel/test-webcrypto-export-import-ec.js Outdated
jasnell approved these changes Nov 19, 2023
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with a new linting nits

panva added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 20, 2023
lpinca added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 22, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2023

nodejs-github-bot commented Nov 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55860/

RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 24, 2023
RafaelGSS reviewed Nov 24, 2023
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@cricciardi apparently, your commit don't include email and username. Can you --resetAuthor after configuring your git? (git config user.name ...)

cricciardi commented Nov 24, 2023

Copy link
Copy Markdown
Contributor Author

@RafaelGSS I updated my commit with username and password

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2023

nodejs-github-bot commented Nov 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55954/

nodejs-github-bot commented Dec 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56200/

nodejs-github-bot commented Dec 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56307/

RafaelGSS commented Dec 15, 2023

Copy link
Copy Markdown
Member

@cricciardi If you see the commit list you will notice the first commit doesn't belong to your github account, can you fix it, please? Basically, just squash all the commits into one and make sure to run git commit --amend --resetAuthor

cricciardi commented Dec 20, 2023

Copy link
Copy Markdown
Contributor Author

Hi @RafaelGSS,
I try to squash commits and set author with this commands:

git rebase --interactive HEAD~20  (set squash on my commit, pick in other commits, and edit on my first commit)
git commit --amend --author="Chiara Ricciardi <chiara.ricciardi66.cr@gmail.com>" (this command for set author)

But it seems not works. Can you tell me what I do wrong?

RafaelGSS commented Dec 21, 2023

Copy link
Copy Markdown
Member

Hi @RafaelGSS, I try to squash commits and set author with this commands:

git rebase --interactive HEAD~20  (set squash on my commit, pick in other commits, and edit on my first commit)
git commit --amend --author="Chiara Ricciardi <chiara.ricciardi66.cr@gmail.com>" (this command for set author)

But it seems not works. Can you tell me what I do wrong?

You need to set squash in all other commits but the first commit

marco-ippolito commented Dec 21, 2023

Copy link
Copy Markdown
Member

User @cricciardi reached out and asked me to fix the commit

deps: update simdutf to 4.0.4
23ea6c8 
PR-URL: nodejs#50772
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

cricciardi commented Dec 21, 2023

Copy link
Copy Markdown
Contributor Author

Hi @marco-ippolito and @RafaelGSS, I open a new PR #51249

cricciardi closed this Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

RafaelGSS RafaelGSS left review comments
jasnell jasnell approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL