FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update ngtcp2 to 1.1.0 by nodejs-github-bot · Pull Request #50808 · nodejs/node · GitHub

/ node Public

deps: update ngtcp2 to 1.1.0 - #50808

Closed
nodejs-github-bot wants to merge 2 commits into
mainfrom
actions/tools-update-ngtcp2
ConversationCommits (2)ChecksFiles changed
Closed

deps: update ngtcp2 to 1.1.0#50808
nodejs-github-bot wants to merge 2 commits into
mainfrom
actions/tools-update-ngtcp2

Conversation

nodejs-github-bot commented Nov 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This is an automated update of ngtcp2 to 1.1.0.

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Nov 19, 2023

marco-ippolito commented Nov 21, 2023

Copy link
Copy Markdown
Member

it seems a build failure @jasnell

jasnell commented Nov 24, 2023

Copy link
Copy Markdown
Member

Yes, we can't rely on the auto updater for this or nghttp3 just yet. I'll be working on this soon.

nodejs-github-bot changed the title deps: update ngtcp2 to 1.0.1 deps: update ngtcp2 to 1.1.0 Dec 3, 2023
targos force-pushed the actions/tools-update-ngtcp2 branch from e8e3482 to d115916 Compare December 23, 2023 11:09

targos commented Dec 23, 2023

Copy link
Copy Markdown
Member

Just rebased, fixed the conflict and updated the gyp file.

targos force-pushed the actions/tools-update-ngtcp2 branch from d115916 to aa87692 Compare December 23, 2023 13:40

targos commented Dec 23, 2023

Copy link
Copy Markdown
Member

@jasnell The update script and build of ngtcp2 should be fixed. Now our quic code needs to be adapted.

jasnell commented Dec 23, 2023

Copy link
Copy Markdown
Member

Yep, I'll be working on it this next week :-)

lpinca commented Dec 27, 2023

Copy link
Copy Markdown
Member

Closing in favor of #51291.

lpinca closed this Dec 27, 2023
lpinca deleted the actions/tools-update-ngtcp2 branch December 27, 2023 06:24

lpinca commented Dec 27, 2023

Copy link
Copy Markdown
Member

The changes to the update script should probably be cherry-picked in #51291.

targos commented Dec 27, 2023

Copy link
Copy Markdown
Member

I opened #51294 with a generalized version

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL