FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix unix abstract socket path for trace event by theanarkh · Pull Request #50858 · nodejs/node · GitHub

/ node Public

src: fix unix abstract socket path for trace event - #50858

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:fix_pipe_path
Dec 23, 2023
ConversationCommits (1)ChecksFiles changed
Merged

src: fix unix abstract socket path for trace event#50858
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:fix_pipe_path

Conversation

theanarkh commented Nov 22, 2023

Copy link
Copy Markdown
Contributor

'\0' in the unix abstract socket causes the path in the trace event to be empty. We'll skip the '\0' and mark the path type with path_type.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Nov 22, 2023
theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2023

This comment was marked as outdated.

Sign in to view
theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2023

This comment was marked as outdated.

Sign in to view
theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2023

This comment was marked as outdated.

Sign in to view
theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2023

This comment was marked as outdated.

Sign in to view
marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2023

nodejs-github-bot commented Dec 21, 2023 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56436/ 💛

jasnell added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Dec 23, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2023
nodejs-github-bot merged commit e266bb1 into nodejs:main Dec 23, 2023

nodejs-github-bot commented Dec 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in e266bb1

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
src: fix unix abstract socket path for trace event
17c73e6 
PR-URL: #50858
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
src: fix unix abstract socket path for trace event
2ce8b97 
PR-URL: #50858
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. net Issues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL