benchmark: update iterations in benchmark/crypto/get-ciphers.js - #50863
Merged
nodejs-github-bot merged 1 commit intoDec 2, 2023
Merged
benchmark: update iterations in benchmark/crypto/get-ciphers.js#50863nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
You already updated the get-ciphers at: https://github.com/nodejs/node/pull/50861/files#diff-18aec8a200905e49e047c06939918db3ef51e9d59bd868b72139b5989a47247eR6 |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
I have updated that PR removing ciphers, and also updated the commit msg of this PR. Could you please go ahead to approve this PR. Thanks! |
Sorry, something went wrong.
H4ad
approved these changes
Nov 27, 2023
H4ad
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for the PR
Sorry, something went wrong.
This comment was marked as duplicate.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the 500 iteration to 50000 to reflect the real ciphers perf. The single iteration n=1 can not make the score reasonable.
Refs: #50571
before:
crypto/get-ciphers.js v="crypto" n=1: 1,852.3492419260726
crypto/get-ciphers.js v="tls" n=1: 1,405.8034377517265
crypto/get-ciphers.js v="crypto" n=5000: 6,147,294.084090065
crypto/get-ciphers.js v="tls" n=5000: 4,488,971.047034541
after
crypto/get-ciphers.js v="crypto" n=1: 1,879.232972270038
crypto/get-ciphers.js v="tls" n=1: 1,430.8526164570944
crypto/get-ciphers.js v="crypto" n=500000: 9,035,846.449813219
crypto/get-ciphers.js v="tls" n=500000: 19,212,295.13113179