benchmark: update iteration and size in benchmark/crypto/randomBytes.js - #50868
Merged
nodejs-github-bot merged 3 commits intoDec 9, 2023
Merged
benchmark: update iteration and size in benchmark/crypto/randomBytes.js#50868nodejs-github-bot merged 3 commits into
nodejs-github-bot merged 3 commits into
Conversation
Copy link
Copy Markdown
Author
|
Test ASan should not fail. |
Sorry, something went wrong.
H4ad
requested changes
Nov 26, 2023
Comment thread
benchmark/crypto/randomBytes.js
Outdated
Comment thread
benchmark/crypto/randomBytes.js
Outdated
Copy link
Copy Markdown
Member
No worries, I can restart later, sometimes it fails for no reason. Also, can you update the first commit message to be similar to: Septa2112@a13bb22 |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
Done. |
Sorry, something went wrong.
H4ad
approved these changes
Dec 2, 2023
H4ad
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Approved with just a little fix on linter.
Sorry, something went wrong.
Comment thread
benchmark/crypto/randomBytes.js
Outdated
Co-authored-by: Vinicius Lourenço <12551007+H4ad@users.noreply.github.com>
jasnell
approved these changes
Dec 9, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase iteration value from 1000 to 10000 to reflect real performance of randomBytes generation. The randomInt has no need to apply this.
Fixes: #50571
Below is the score improvment measured on cascadelake server: