benchmark: increase iteration counts for 4 cases - #50869
Merged
nodejs-github-bot merged 1 commit intoDec 10, 2023
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Can you please update the first commit message to something like: Septa2112@a13bb22 Maybe benchmark: update iterations in perf_hooks. Also, how are you generating this percent metric? |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
please update the first commit message to something like: Septa2112@a13bb22
I wrote a script to compare the before and after score. As the perf_hooks testing methods are only a few, so I will not split the commit. I have updated the commit msg. Could you please go ahead to approve it? Thanks! |
Sorry, something went wrong.
H4ad
approved these changes
Nov 27, 2023
H4ad
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for the PR
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/50869 ✔ Done loading data for nodejs/node/pull/50869 ----------------------------------- PR info ------------------------------------ Title benchmark: increase iteration counts for 4 cases (#50869) Author Lei Shi (@lucshi) Branch lucshi:my-branch-5 -> nodejs:main Labels benchmark, author ready, perf_hooks Commits 1 - benchmark: update iterations in benchmark/perf_hooks Committers 1 - Lei Shi PR-URL: https://github.com/nodejs/node/pull/50869 Refs: https://github.com/nodejs/node/issues/50571 Reviewed-By: Vinícius Lourenço Claro Cardoso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50869 Refs: https://github.com/nodejs/node/issues/50571 Reviewed-By: Vinícius Lourenço Claro Cardoso -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 23 Nov 2023 07:06:59 GMT ✔ Approvals: 1 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50869#pullrequestreview-1750127621 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50869 From https://github.com/nodejs/node * branch refs/pull/50869/merge -> FETCH_HEAD ✔ Fetched commits as 27b2ce5ba633..3c6f29b785d1 -------------------------------------------------------------------------------- error: cherry-pick is already in progress hint: try "git cherry-pick (--continue | --abort | --quit)" fatal: cherry-pick failed ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/7105099049 |
Sorry, something went wrong.
jasnell
approved these changes
Dec 9, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the iteration counts to 10X to reflect real performance of perf hooks timing.
Refs: #50571
Belowing are the improved ratio with 10X iteration:
performance-observer.js
./node/benchmark//perf_hooks/performance-observer.js n=1000000
perf_hooks/performance-observer.js pending=1 n=1000000 percent=111.33%
perf_hooks/performance-observer.js pending=10 n=1000000 percent=127.58%
resourcetiming.js
./node/benchmark//perf_hooks/resourcetiming.js n=1000000
perf_hooks/resourcetiming.js observe="resource" n=1000000 percent=135.24%
timerfied.js
./node/benchmark//perf_hooks/timerfied.js n=1000000
perf_hooks/timerfied.js observe="function" n=1000000 percent=116.11%
usertiming.js
./node/benchmark//perf_hooks/usertiming.js n=1000000
perf_hooks/usertiming.js observe="all" n=1000000 percent=823.76%
perf_hooks/usertiming.js observe="measure" n=1000000 percent=1039.62%