FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add doc for Unix abstract socket by theanarkh · Pull Request #50904 · nodejs/node · GitHub

/ node Public

doc: add doc for Unix abstract socket - #50904

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:update_doc_for_unix_abstract_socket
Nov 28, 2023
ConversationCommits (1)ChecksFiles changed
Merged

doc: add doc for Unix abstract socket#50904
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:update_doc_for_unix_abstract_socket

Conversation

theanarkh commented Nov 25, 2023

Copy link
Copy Markdown
Contributor

Refs: #49667

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Nov 25, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Nov 25, 2023
theanarkh added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 26, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 28, 2023
nodejs-github-bot merged commit 69866bf into nodejs:main Nov 28, 2023

nodejs-github-bot commented Nov 28, 2023

Copy link
Copy Markdown
Collaborator

Landed in 69866bf

targos pushed a commit that referenced this pull request Dec 4, 2023
doc: add doc for Unix abstract socket
eecab88 
PR-URL: #50904
Refs: #49667
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
targos mentioned this pull request Dec 4, 2023
Merged

zobo commented Mar 11, 2024

Copy link
Copy Markdown
Contributor

I think it should be added that abstract UNIX sockets are actually working only on versions >=v20.8.0

theanarkh mentioned this pull request Mar 11, 2024
Merged
4 tasks

theanarkh commented Mar 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I think it should be added that abstract UNIX sockets are actually working only on versions >=v20.8.0

Thanks ! I have opened a PR to add this.

nodejs-github-bot pushed a commit that referenced this pull request Mar 19, 2024
doc: optimize the doc about Unix abstract socket
7071554 
PR-URL: #52043
Refs: #50904
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
doc: add doc for Unix abstract socket
5f8e7a0 
PR-URL: #50904
Refs: #49667
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
richardlau mentioned this pull request Mar 25, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
doc: optimize the doc about Unix abstract socket
7857cfb 
PR-URL: #52043
Refs: #50904
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
doc: optimize the doc about Unix abstract socket
bda3cde 
PR-URL: #52043
Refs: #50904
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ShogunPanda ShogunPanda approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL