FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove unused headers in `node_file.cc` by pluris · Pull Request #50927 · nodejs/node · GitHub

/ node Public

src: remove unused headers in node_file.cc - #50927

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pluris:fix/remove_unused_header
Dec 10, 2023
ConversationCommits (1)ChecksFiles changed
Merged

src: remove unused headers in node_file.cc#50927
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pluris:fix/remove_unused_header

Conversation

pluris commented Nov 27, 2023

Copy link
Copy Markdown
Contributor

I have cleaned up unused headers in node_file.cc.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 27, 2023
arxngr reviewed Nov 27, 2023
View reviewed changes
Comment thread src/node_file.cc Outdated

arxngr Nov 27, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

why this is removed? what if the compiler is using MinGW? it will miss something from io.h, or is some library already included from another header file?

pluris Nov 27, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Headers declared in .cc file are used internally only within the .cc file.
This code was added in the commit below.
bce41fa#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6
At that time, there was code that was used internally to define __MINGW32__ and _MSC_VER, but it is no longer present.

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2023

nodejs-github-bot commented Nov 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55949/

pluris force-pushed the fix/remove_unused_header branch from 77b7761 to 4a1e1ba Compare November 27, 2023 13:53
deokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2023

nodejs-github-bot commented Nov 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55974/

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2023
nodejs-github-bot merged commit a768d89 into nodejs:main Dec 10, 2023

nodejs-github-bot commented Dec 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in a768d89

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
src: remove unused headers in node_file.cc
fc55032 
PR-URL: #50927
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
src: remove unused headers in node_file.cc
358793e 
PR-URL: #50927
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
+1 more reviewer
arxngr arxngr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL