FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: update iterations in benchmark/util/inspect-array.js by lucshi · Pull Request #50933 · nodejs/node · GitHub

/ node Public

benchmark: update iterations in benchmark/util/inspect-array.js - #50933

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lucshi:util/inspect-array.js
Dec 4, 2023
ConversationCommits (1)ChecksFiles changed
Merged

benchmark: update iterations in benchmark/util/inspect-array.js#50933
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lucshi:util/inspect-array.js

Conversation

lucshi commented Nov 27, 2023 •
edited by H4ad
Loading

Copy link
Copy Markdown

Refs: #50571

Belowing are the score improvement after 10X iteration change:

util/inspect-array.js n=5000
util/inspect-array.js type="denseArray"  n=5000 percent=159.84%
util/inspect-array.js type="sparseArray"  n=5000 percent=245.72%
util/inspect-array.js type="denseArray_showHidden"  n=5000 percent=158.26%
util/inspect-array.js type="denseArray"  n=5000 percent=164.69%
util/inspect-array.js type="denseArray_showHidden"  n=5000 percent=158.53%

nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module. labels Nov 27, 2023
H4ad added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 2, 2023
H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2023
nodejs-github-bot merged commit 964046d into nodejs:main Dec 4, 2023

nodejs-github-bot commented Dec 4, 2023

Copy link
Copy Markdown
Collaborator

Landed in 964046d

H4ad commented Dec 4, 2023

Copy link
Copy Markdown
Member

@UlisesGascon do you know why your email was not included in the commit as reviewer?

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
benchmark: update iterations in benchmark/util/inspect-array.js
dbee03d 
Fixes: #50571
PR-URL: #50933
Refs: #50571
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
benchmark: update iterations in benchmark/util/inspect-array.js
4fc83e1 
Fixes: #50571
PR-URL: #50933
Refs: #50571
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

UlisesGascon UlisesGascon approved these changes
H4ad H4ad approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL