doc: remove flicker on page load on dark theme - #50942
Merged
nodejs-github-bot merged 1 commit intoNov 27, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Theme applying logic get loaded and executed in async mode, so often there is a delay in applying the proper theme to a page which leads to flicker on dark theme. Resolved by moving critical logic to the page head
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
MoLow
approved these changes
Nov 27, 2023
ovflowd
approved these changes
Nov 27, 2023
ovflowd
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This whole thing feels hacky, but hey, the whole codebase has been long-time hacky.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @ovflowd. Please 👍 to approve. |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Dec 4, 2023
Theme applying logic get loaded and executed in async mode, so often there is a delay in applying the proper theme to a page which leads to flicker on dark theme. Resolved by moving critical logic to the page head PR-URL: #50942 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Theme applying logic get loaded and executed in async mode, so often there is a delay in applying the proper theme to a page which leads to flicker on dark theme. Resolved by moving critical logic to the page head PR-URL: #50942 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Merged
aduh95
pushed a commit
that referenced
this pull request
Feb 10, 2025
Theme applying logic get loaded and executed in async mode, so often there is a delay in applying the proper theme to a page which leads to flicker on dark theme. Resolved by moving critical logic to the page head PR-URL: #50942 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theme applying logic gets loaded and executed in async mode, so often there is a
delay in applying the proper theme to a page which leads to flicker on dark theme.
Resolved by moving critical logic to the page head (sync script). No impact on performance was detected.
Before:
UI
Performance
After:
UI
Performance