FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: support child_process synchronous methods in custom snapshot by joyeecheung · Pull Request #50943 · nodejs/node · GitHub

/ node Public

src: support child_process synchronous methods in custom snapshot - #50943

Closed
joyeecheung wants to merge 4 commits into
nodejs:mainfrom
joyeecheung:child-process-snapshot
ConversationCommits (4)ChecksFiles changed
Closed

src: support child_process synchronous methods in custom snapshot#50943
joyeecheung wants to merge 4 commits into
nodejs:mainfrom
joyeecheung:child-process-snapshot

Conversation

joyeecheung commented Nov 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

src: register process_wrap external references

src: register spawn_sync external references

src: register udp_wrap external references

test: test syncrhnous methods of child_process in snapshot

These currently work in snapshot builder scripts. Asynchronous
methods are not supported yet.

Refs: #50924

nodejs-github-bot commented Nov 27, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net
  • @nodejs/startup

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 27, 2023
joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2023

nodejs-github-bot commented Nov 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56020/

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2023

nodejs-github-bot commented Dec 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56056/

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2023

nodejs-github-bot commented Dec 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56100/

nodejs-github-bot commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56133/

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2023

nodejs-github-bot commented Dec 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56230/

test: test syncrhnous methods of child_process in snapshot
3c77d71 
These currently work in snapshot builder scripts. Asynchronous
methods are not supported yet.
joyeecheung force-pushed the child-process-snapshot branch from 2d4520c to 3c77d71 Compare December 13, 2023 00:23

joyeecheung commented Dec 13, 2023

Copy link
Copy Markdown
Member Author

Fixed linter errors

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2023

nodejs-github-bot commented Dec 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56260/

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2023

nodejs-github-bot commented Dec 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56262/

nodejs-github-bot commented Dec 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56288/

nodejs-github-bot commented Dec 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56292/

joyeecheung added a commit that referenced this pull request Dec 14, 2023
src: register process_wrap external references
b27f1ca 
PR-URL: #50943
Refs: #50924
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit that referenced this pull request Dec 14, 2023
src: register spawn_sync external references
0473d32 
PR-URL: #50943
Refs: #50924
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit that referenced this pull request Dec 14, 2023
src: register udp_wrap external references
4d49aff 
PR-URL: #50943
Refs: #50924
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit that referenced this pull request Dec 14, 2023
test: test syncrhnous methods of child_process in snapshot
5fd5c1e 
These currently work in snapshot builder scripts. Asynchronous
methods are not supported yet.

PR-URL: #50943
Refs: #50924
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung commented Dec 14, 2023

Copy link
Copy Markdown
Member Author

Landed in 429ec83...5fd5c1e

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
src: register process_wrap external references
2cfee53 
PR-URL: #50943
Refs: #50924
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
src: register spawn_sync external references
84e2f51 
PR-URL: #50943
Refs: #50924
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
src: register udp_wrap external references
abe9052 
PR-URL: #50943
Refs: #50924
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
test: test syncrhnous methods of child_process in snapshot
aee01ff 
These currently work in snapshot builder scripts. Asynchronous
methods are not supported yet.

PR-URL: #50943
Refs: #50924
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
src: register process_wrap external references
642fb44 
PR-URL: #50943
Refs: #50924
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
src: register spawn_sync external references
b05d496 
PR-URL: #50943
Refs: #50924
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
src: register udp_wrap external references
9365e12 
PR-URL: #50943
Refs: #50924
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
test: test syncrhnous methods of child_process in snapshot
6319ea6 
These currently work in snapshot builder scripts. Asynchronous
methods are not supported yet.

PR-URL: #50943
Refs: #50924
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
joyeecheung mentioned this pull request Jun 6, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
benjamingr benjamingr approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL