FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: omit non-string values of package.json main field by anonrig · Pull Request #50965 · nodejs/node · GitHub

/ node Public

src: omit non-string values of package.json main field - #50965

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:fix-package-json-main
Dec 3, 2023
ConversationCommits (1)ChecksFiles changed
Merged

src: omit non-string values of package.json main field#50965
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:fix-package-json-main

Conversation

anonrig commented Nov 29, 2023

Copy link
Copy Markdown
Member

Omit "main": false in package.json and do not throw an error for it.

FYI: This PR has missing tests.

cc @RafaelGSS @targos @nodejs/loaders

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 29, 2023
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2023

nodejs-github-bot commented Nov 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56006/

targos commented Nov 29, 2023

Copy link
Copy Markdown
Member

It's not just boolean values that were ignored. I don't know exactly what is the current behavior but at least numbers and null are also ignored.
I think the safest fix is to ignore anything that's not a string.

anonrig force-pushed the fix-package-json-main branch from d2ea291 to 61523db Compare November 29, 2023 14:00

anonrig commented Nov 29, 2023

Copy link
Copy Markdown
Member Author

It's not just boolean values that were ignored. I don't know exactly what is the current behavior but at least numbers and null are also ignored. I think the safest fix is to ignore anything that's not a string.

I see. I updated the PR. Thank you @targos

anonrig force-pushed the fix-package-json-main branch from 61523db to 7e3b1b6 Compare November 29, 2023 14:00
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2023

nodejs-github-bot commented Nov 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56008/

RafaelGSS reviewed Nov 29, 2023
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Shoudn't it be wip until tests are added?

anonrig commented Nov 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Shoudn't it be wip until tests are added?

If this is excluded in v20 release, I'll spend more time to add tests in this PR. If not, we can merge it as it is to unblock the release.

GeoffreyBooth commented Nov 29, 2023

Copy link
Copy Markdown
Member

Shoudn’t it be wip until tests are added?

I’m not really sure it needs tests, to be honest, because Node itself doesn’t take a position on non-string values of package.json values AFAIK. This is to fix CITGM tests that break, and it’s also debatable whether those tests are correct. We may very well want to support values like "main": false in the future, so adding a test now to prohibit that in the future would box us in.

ljharb commented Nov 29, 2023

Copy link
Copy Markdown
Member

Can the PR title be updated to match the current PR’s behavior?

anonrig changed the title src: omit bool values of package.json main field src: omit non-string values of package.json main field Nov 29, 2023
anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 29, 2023

aduh95 commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

adding a test now to prohibit that in the future would box us in.

It would not, it's definitely OK to change tests in semver-major PRs. Not having a test only gives a chance that such breaking change slips through in a semver-minor or semver-patch PR.

anonrig commented Nov 29, 2023

Copy link
Copy Markdown
Member Author

adding a test now to prohibit that in the future would box us in.

It would not, it's definitely OK to change tests in semver-major PRs. Not having a test only gives a chance that such breaking change slips through in a semver-minor or semver-patch PR.

If we add tests, any change we make in the future will be semver-major but we don't claim that we support non-string use cases since they are invalid. I think this is the correct approach.

ljharb commented Nov 30, 2023

Copy link
Copy Markdown
Member

The tests don't map to claimed support though, do they?

targos commented Nov 30, 2023

Copy link
Copy Markdown
Member

It's better to catch regression in tests instead of citgm

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 3, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 3, 2023
nodejs-github-bot merged commit 0229502 into nodejs:main Dec 3, 2023

nodejs-github-bot commented Dec 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in 0229502

targos commented Dec 4, 2023

Copy link
Copy Markdown
Member

Depends on #50322

anonrig commented Dec 4, 2023

Copy link
Copy Markdown
Member Author

@targos Why did we add don't-land-on-v21? The dependent PR issue is fixed in this PR and therefore, we can remove the do not land issues on this PR and parent PR.

targos commented Dec 4, 2023

Copy link
Copy Markdown
Member

Feel free to change labels on both PRs if that's the correct thing to do. I just acted based on the parent PR labels.

anonrig mentioned this pull request Dec 4, 2023
Closed
8 tasks
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
src: omit bool values of package.json main field
9bf1443 
PR-URL: #50965
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS mentioned this pull request Dec 15, 2023
Merged

marco-ippolito commented May 2, 2024

Copy link
Copy Markdown
Member

to land on v20 dependes on #50965

marco-ippolito mentioned this pull request May 2, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

RafaelGSS RafaelGSS left review comments
GeoffreyBooth GeoffreyBooth approved these changes
benjamingr benjamingr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL