vm: use v8::DeserializeInternalFieldsCallback explicitly - #50984
Closed
joyeecheung wants to merge 2 commits into
Closed
vm: use v8::DeserializeInternalFieldsCallback explicitly#50984joyeecheung wants to merge 2 commits into
joyeecheung wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
anonrig
approved these changes
Nov 30, 2023
tniessen
approved these changes
Nov 30, 2023
daeyeon
approved these changes
Dec 1, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Dec 9, 2023
legendecas
approved these changes
Dec 11, 2023
Copy link
Copy Markdown
Member
|
I don't think "contextify" is a valid subsystem in the commit message. Maybe src is fine. |
Sorry, something went wrong.
To avoid ambiguity in the signature.
joyeecheung
force-pushed
the
context-slot-pre
branch
from
db7c4ea to
5bd7871
Compare
December 11, 2023 14:31
Copy link
Copy Markdown
Member
Author
|
Updated to use vm: in the commit message |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Need to run format-cpp as well. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Ran format-cpp |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
joyeecheung
added a commit
that referenced
this pull request
Dec 14, 2023
To avoid ambiguity in the signature. PR-URL: #50984 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Dec 15, 2023
To avoid ambiguity in the signature. PR-URL: #50984 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
To avoid ambiguity in the signature. PR-URL: #50984 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid ambiguity in the signature.
This is necessary for the integration tests in https://chromium-review.googlesource.com/c/v8/v8/+/5074252 to pass which in turn unblocks #50983