module: load source maps in commonjs translator - #51033
Merged
nodejs-github-bot merged 1 commit intoDec 13, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
privatenumber
marked this pull request as ready for review
December 3, 2023 16:52
privatenumber
force-pushed
the
50649
branch
2 times, most recently
from
a3234b7 to
b43f701
Compare
December 3, 2023 17:08
aduh95
approved these changes
Dec 3, 2023
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@nodejs/loaders |
Sorry, something went wrong.
Comment thread
test/es-module/test-esm-loader-hooks.mjs
Outdated
Comment thread
test/es-module/test-esm-loader-hooks.mjs
Outdated
aduh95
reviewed
Dec 5, 2023
Comment thread
test/es-module/test-esm-loader-hooks.mjs
Outdated
aduh95
approved these changes
Dec 5, 2023
GeoffreyBooth
approved these changes
Dec 5, 2023
GeoffreyBooth
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
approved these changes
Dec 5, 2023
Copy link
Copy Markdown
Contributor
|
@privatenumber can you please rebase all your commits on top of main? Merge commits tend to break our tooling |
Sorry, something went wrong.
jasnell
approved these changes
Dec 9, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
RafaelGSS
pushed a commit
that referenced
this pull request
Dec 15, 2023
PR-URL: #51033 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
6 tasks
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51033 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #50839
Development command (for future reference):
make -s build-addons && tools/test.py test/es-module/test-esm-loader-hooks.mjs