module: document parentURL in register options - #51039
Merged
nodejs-github-bot merged 1 commit intoDec 6, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
aduh95
reviewed
Dec 4, 2023
Comment thread
doc/api/module.md
Outdated
privatenumber
force-pushed
the
module-docs-parentURL
branch
from
5ab0d1c to
03fba68
Compare
December 4, 2023 13:02
aduh95
reviewed
Dec 4, 2023
Comment thread
doc/api/module.md
Outdated
aduh95
approved these changes
Dec 4, 2023
Copy link
Copy Markdown
Member
|
Can you please confirm that it is supported there? I remember us debating whether to support parentURL as the second argument or within options or both; I know it’s supported as the second argument, is it also supported in options? If it’s supported in both, is that what we want? What happens if you define it in both places? |
Sorry, something went wrong.
lpinca
approved these changes
Dec 4, 2023
Copy link
Copy Markdown
Member
This was answered in #51039 (comment) |
Sorry, something went wrong.
JakobJingleheimer
approved these changes
Dec 4, 2023
GeoffreyBooth
approved these changes
Dec 5, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/51039 ✔ Done loading data for nodejs/node/pull/51039 ----------------------------------- PR info ------------------------------------ Title module: document `parentURL` in register options (#51039) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch privatenumber:module-docs-parentURL -> nodejs:main Labels doc, module, author ready Commits 3 - module: document parentURL in register options - Merge branch 'main' into module-docs-parentURL - Update doc/api/module.md Committers 2 - Hiroki Osame - GitHub PR-URL: https://github.com/nodejs/node/pull/51039 Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Jacob Smith Reviewed-By: Geoffrey Booth ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51039 Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Jacob Smith Reviewed-By: Geoffrey Booth -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 04 Dec 2023 05:08:14 GMT ✔ Approvals: 4 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/51039#pullrequestreview-1763062424 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51039#pullrequestreview-1763255497 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/51039#pullrequestreview-1763362015 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/51039#pullrequestreview-1763999641 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51039 From https://github.com/nodejs/node * branch refs/pull/51039/merge -> FETCH_HEAD ✔ Fetched commits as ac9e594e3224..243207ade200 -------------------------------------------------------------------------------- error: commit 042ae1fc72072eaa78b12f928629593efbeba626 is a merge but no -m option was given. fatal: cherry-pick failed [main e2151c7755] module: document parentURL in register options Author: Hiroki Osame Date: Mon Dec 4 14:06:04 2023 +0900 1 file changed, 4 insertions(+) ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/7110494786 |
Sorry, something went wrong.
privatenumber
force-pushed
the
module-docs-parentURL
branch
from
e1ceacf to
50b808e
Compare
December 6, 2023 06:37
aduh95
approved these changes
Dec 6, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Dec 15, 2023
PR-URL: #51039 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51039 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parentURL property was missing in options documentation
Development
Ran make test-doc to lint docs