doc: use length argument in pbkdf2Key - #51066
Merged
nodejs-github-bot merged 1 commit intoDec 7, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The optional `length` argument is supposed to determine the length of the AES-GCM key, so it may be 128, 192, or 256.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
marco-ippolito
approved these changes
Dec 6, 2023
panva
approved these changes
Dec 6, 2023
lpinca
approved these changes
Dec 6, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Dec 15, 2023
The optional `length` argument is supposed to determine the length of the AES-GCM key, so it may be 128, 192, or 256. PR-URL: #51066 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
The optional `length` argument is supposed to determine the length of the AES-GCM key, so it may be 128, 192, or 256. PR-URL: #51066 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optional length argument is supposed to determine the length of the AES-GCM key, so it may be 128, 192, or 256.