doc: correct tracingChannel.traceCallback() - #51068
Merged
nodejs-github-bot merged 2 commits intoDec 8, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Flarna
force-pushed
the
gst/diag-channel-trace-callback
branch
from
481f145 to
e1e19b5
Compare
December 6, 2023 07:48
tracingChannel.traceCallback() requires a callback otherwise it throws and invalid argument error. As a result arguments are not optional. Correct the documentation to reflect that arguments are not optional. Besides that correct description regarding signaling of errors. Remove an unneeded null check in wrappedCallback() which can't happen because it's validated that callback is of type function.
Flarna
force-pushed
the
gst/diag-channel-trace-callback
branch
from
e1e19b5 to
1559cd8
Compare
December 6, 2023 07:58
Qard
approved these changes
Dec 6, 2023
Qard
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Other than typo, LGTM.
Sorry, something went wrong.
Comment thread
doc/api/diagnostics_channel.md
Outdated
Qard
approved these changes
Dec 6, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Dec 7, 2023
VoltrexKeyva
approved these changes
Dec 8, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Dec 15, 2023
tracingChannel.traceCallback() requires a callback otherwise it throws and invalid argument error. As a result arguments are not optional. Correct the documentation to reflect that arguments are not optional. Besides that correct description regarding signaling of errors. Remove an unneeded null check in wrappedCallback() which can't happen because it's validated that callback is of type function. PR-URL: #51068 Fixes: #50996 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
tracingChannel.traceCallback() requires a callback otherwise it throws and invalid argument error. As a result arguments are not optional. Correct the documentation to reflect that arguments are not optional. Besides that correct description regarding signaling of errors. Remove an unneeded null check in wrappedCallback() which can't happen because it's validated that callback is of type function. PR-URL: #51068 Fixes: #50996 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracingChannel.traceCallback() requires a callback otherwise it throws and invalid argument error. As a result arguments are not optional.
Correct the documentation to reflect that arguments are not optional.
Besides that correct description regarding signaling of errors.
Remove an unneeded null check in wrappedCallback() which can't happen because it's validated that callback is of type function.
Fixes: #50996