build: fix warnings from uv for gn build - #51069
Merged
nodejs-github-bot merged 1 commit intoDec 6, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
gengjiawen
approved these changes
Dec 6, 2023
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @gengjiawen. Please 👍 to approve. |
Sorry, something went wrong.
This was referenced Dec 6, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
santigimeno
approved these changes
Dec 6, 2023
lpinca
approved these changes
Dec 6, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Dec 15, 2023
PR-URL: #51069 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51069 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build failure in GN build caused by upgrade of libuv in #50650, a fast track merge would be appreciated so we can bring CI of GN build to green to continue monitoring the health of GN build .
../../node/deps/uv/src/idna.c:385:30: error: parameter 'w_target_len' set but not used [-Werror,-Wunused-but-set-parameter] 385 | size_t w_target_len) { | ^ 1 error generated.Note that this parameter was intentionally used by libuv for safety check without being "used", so fixing it in libuv would be tricky as we need to tell the compiler the parameter is used.
https://github.com/libuv/libuv/blob/5e302730cd29cfeb15d32369dd2edfd9d3c82c11/src/idna.c#L383-L404
I'll try to fix it (and some other compiler warnings) in libuv but it will be really helpful to merge this first.